docs(drive): document trusted-state rationale for bincode NoLimit

[QuantumExplorer]

Summary

• Adds SAFETY comments to CompactedNullifiers::bincode_config() and NullifierExpirationRanges::bincode_config() explaining why with_no_limit() is intentional
• GroveDB state is trusted — if storage-level corruption occurs, artificial deserialization limits would mask the real problem rather than providing meaningful protection

Context

Security audit flagged with_no_limit() as a potential DoS vector (L7). After review, this was determined to be a false positive: this data is only deserialized from GroveDB's own trusted state, never from untrusted external input. Adding this comment to prevent future auditors from re-investigating.

Test plan

• Documentation-only change, no logic changes

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation
  • Added clarifying documentation comments to explain internal configuration settings and their rationale.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cf051c56-1e6d-4329-8f85-45607f91e403

📥 Commits

Reviewing files that changed from the base of the PR and between 0bf58ab and 2e39bd0.

📒 Files selected for processing (1)

• packages/rs-drive/src/drive/shielded/nullifiers/types.rs

---

📝 Walkthrough

Walkthrough

Added SAFETY documentation comments to the bincode_config() helper in CompactedNullifiers and NullifierExpirationRanges to explain the intentional use of with_no_limit() for trusted GroveDB state data. No functional changes.

Changes

Cohort / File(s)	Summary
Documentation Enhancement packages/rs-drive/src/drive/shielded/nullifiers/types.rs	Added SAFETY documentation comments explaining the intentional use of with_no_limit() in bincode configuration for two types, noting that data originates from trusted GroveDB state and limiting would mask potential issues.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A safety note, so clear and true,
Marks the limit-free path we pursue,
From GroveDB's trusted ground,
No bounds shall be found—
Documentation shines bright and brand new!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding documentation comments explaining the rationale for using bincode's NoLimit configuration in the context of trusted state.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch docs/trusted-state-bincode-comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.87%. Comparing base (2fb112c) to head (2e39bd0).
⚠️ Report is 4 commits behind head on v3.1-dev.

Additional details and impacted files

@@            Coverage Diff            @@
##           v3.1-dev    #3370   +/-   ##
=========================================
  Coverage     75.87%   75.87%           
=========================================
  Files          2912     2912           
  Lines        283860   283932   +72     
=========================================
+ Hits         215375   215438   +63     
- Misses        68485    68494    +9     

Components	Coverage Δ
dpp	65.75% <ø> (+0.03%)	⬆️
drive	81.64% <ø> (-0.01%)	⬇️
drive-abci	85.99% <ø> (ø)
sdk	31.25% <ø> (ø)
dapi-client	79.06% <ø> (ø)
platform-version	∅ <ø> (∅)
platform-value	58.46% <ø> (ø)
platform-wallet	60.40% <ø> (ø)
drive-proof-verifier	48.00% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.