Skip to content

ci: exclude SDK integration and wallet code from coverage#3385

Merged
QuantumExplorer merged 2 commits into
v3.1-devfrom
ci/exclude-sdk-wallet-from-coverage
Mar 18, 2026
Merged

ci: exclude SDK integration and wallet code from coverage#3385
QuantumExplorer merged 2 commits into
v3.1-devfrom
ci/exclude-sdk-wallet-from-coverage

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Codecov metrics are skewed by ~2,946 lines of code that cannot be meaningfully unit-tested because they require a running platform node or Core wallet integration.

What was done?

Added 11 new entries to .codecov.yml ignore: section, grouped by category:

SDK integration code (requires running platform node, not unit-testable):

  • packages/rs-sdk/src/platform/dpns_usernames/** — DPNS username operations + contested queries (~946 lines)
  • packages/rs-sdk/src/platform/shielded/nullifier_sync/** — SDK sync logic (335 lines)
  • packages/rs-sdk/src/platform/address_sync/** — address sync (258 lines)
  • packages/rs-sdk/src/platform/dashpay/** — contact requests (217 lines)
  • packages/rs-sdk/src/core/transaction.rs — Core transaction broadcasting (142 lines)
  • packages/rs-sdk/src/platform/documents/transitions/purchase.rs — purchase transitions (137 lines)

DAPI service handlers:

  • packages/rs-dapi/src/services/platform_service/wait_for_state_transition_result.rs — long-polling gRPC handler (180 lines)

Proof verifier boilerplate:

  • packages/rs-drive-proof-verifier/src/types/evonode_status.rs — response type definitions (135 lines)

Drive internals:

  • packages/rs-drive/src/util/object_size_info/path_key_info.rs — internal size estimation (141 lines)

Wallet logic (requires Core wallet integration):

  • packages/rs-platform-wallet/src/platform_wallet_info/matured_transactions.rs — transaction maturation (186 lines)
  • packages/rs-platform-wallet/src/platform_wallet_info/contact_requests.rs — contact request handling (269 lines)

How Has This Been Tested?

Configuration-only change to .codecov.yml. Verified all excluded paths exist in the repository.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

🤖 Generated with Claude Code

Exclude ~2,946 lines of untestable code from Codecov metrics:
- SDK integration code requiring a running platform node (DPNS usernames,
  nullifier sync, address sync, DashPay contacts, Core transactions,
  purchase transitions)
- DAPI gRPC long-polling handler
- Drive-proof-verifier response type boilerplate
- Drive internal size estimation helpers
- Wallet logic requiring Core wallet integration

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@QuantumExplorer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 53 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 22cd4138-0e88-47c6-bc28-30b6dc19fab8

📥 Commits

Reviewing files that changed from the base of the PR and between 0836091 and 4b082c1.

📒 Files selected for processing (1)
  • .codecov.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/exclude-sdk-wallet-from-coverage
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added this to the v3.1.0 milestone Mar 18, 2026
@QuantumExplorer QuantumExplorer merged commit c6206cc into v3.1-dev Mar 18, 2026
6 checks passed
@QuantumExplorer QuantumExplorer deleted the ci/exclude-sdk-wallet-from-coverage branch March 18, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant