build: add rs-unified-sdk-ffi to Dockerfile COPY blocks#3418
Conversation
The rs-unified-sdk-ffi workspace member was added to Cargo.toml but not included in the Dockerfile's COPY --parents blocks, causing cargo chef prepare to fail with "Cannot extract Cargo metadata" during Docker builds. Added the missing package to all four COPY blocks: build-planner, build-drive-abci, build-js, and build-rs-dapi stages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Dockerfile is updated to include Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⏳ Review in progress (commit 0b8a132) |
There was a problem hiding this comment.
Pull request overview
Updates the root Dockerfile to include the newly added Rust workspace member packages/rs-unified-sdk-ffi in all Docker build stages that rely on enumerating workspace members, preventing cargo metadata / cargo chef failures during Docker builds.
Changes:
- Add
packages/rs-unified-sdk-ffito thebuild-plannerCOPY --parentsworkspace list (needed forcargo chef prepare). - Add
packages/rs-unified-sdk-ffito thebuild-drive-abci,build-js, andbuild-rs-dapisourceCOPY --parentsblocks to keep those builds consistent with workspace membership.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Issue being fixed or feature implemented
Docker build fails with
Cannot extract Cargo metadatabecausers-unified-sdk-ffiwas added as a workspace member inCargo.tomlbut not included in the Dockerfile'sCOPY --parentsblocks.What was done?
Added
packages/rs-unified-sdk-ffito all four Dockerfile COPY blocks that enumerate workspace members:cargo chef prepareneeds all workspace members to extract metadataHow Has This Been Tested?
rs-unified-sdk-ffidirectory andCargo.tomlexist in the workspaceCargo.tomlmembersBreaking Changes
None.
Checklist:
🤖 Co-authored by Claudius the Magnificent AI Agent
Summary by CodeRabbit