Skip to content

build: add rs-unified-sdk-ffi to Dockerfile COPY blocks#3418

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
fix/dockerfile-add-rs-unified-sdk-ffi
Mar 31, 2026
Merged

build: add rs-unified-sdk-ffi to Dockerfile COPY blocks#3418
QuantumExplorer merged 1 commit into
v3.1-devfrom
fix/dockerfile-add-rs-unified-sdk-ffi

Conversation

@lklimek

@lklimek lklimek commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Docker build fails with Cannot extract Cargo metadata because rs-unified-sdk-ffi was added as a workspace member in Cargo.toml but not included in the Dockerfile's COPY --parents blocks.

What was done?

Added packages/rs-unified-sdk-ffi to all four Dockerfile COPY blocks that enumerate workspace members:

  1. build-plannercargo chef prepare needs all workspace members to extract metadata
  2. build-drive-abci — source COPY for drive-abci build
  3. build-js — source COPY for JS/WASM build
  4. build-rs-dapi — source COPY for rs-dapi build

How Has This Been Tested?

  • Verified rs-unified-sdk-ffi directory and Cargo.toml exist in the workspace
  • Confirmed the crate is listed in workspace Cargo.toml members
  • Confirmed all four COPY blocks that list workspace members now include the new crate

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

🤖 Co-authored by Claudius the Magnificent AI Agent

Summary by CodeRabbit

  • Chores
    • Optimized Docker build configuration to improve package handling across multiple build stages for enhanced build efficiency.

The rs-unified-sdk-ffi workspace member was added to Cargo.toml but
not included in the Dockerfile's COPY --parents blocks, causing
cargo chef prepare to fail with "Cannot extract Cargo metadata"
during Docker builds.

Added the missing package to all four COPY blocks: build-planner,
build-drive-abci, build-js, and build-rs-dapi stages.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 82de5689-0d66-4356-9599-e75f9c54ce20

📥 Commits

Reviewing files that changed from the base of the PR and between 739754b and 0b8a132.

📒 Files selected for processing (1)
  • Dockerfile

📝 Walkthrough

Walkthrough

The Dockerfile is updated to include packages/rs-unified-sdk-ffi in COPY --parents commands across multiple build stages (build-planner, build-drive-abci, build-js, and build-rs-dapi) to ensure the package is available during dependency resolution and compilation.

Changes

Cohort / File(s) Summary
Docker Build Configuration
Dockerfile
Added packages/rs-unified-sdk-ffi to COPY --parents lists in build-planner stage and subsequent Rust dependency/build stages for proper caching and workspace compilation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A package lost, now found with glee,
In Docker's layers, wild and free,
From planner's stage to builder's call,
rs-unified-sdk-ffi graces them all! 📦

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding rs-unified-sdk-ffi to Dockerfile COPY blocks, which directly addresses the Docker build failure caused by missing this workspace member.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dockerfile-add-rs-unified-sdk-ffi

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added this to the v3.1.0 milestone Mar 31, 2026
@lklimek lklimek changed the title fix(docker): add rs-unified-sdk-ffi to Dockerfile COPY blocks build: add rs-unified-sdk-ffi to Dockerfile COPY blocks Mar 31, 2026
@lklimek lklimek requested a review from Copilot March 31, 2026 11:50
@lklimek lklimek marked this pull request as ready for review March 31, 2026 11:50
@thepastaclaw

thepastaclaw commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

⏳ Review in progress (commit 0b8a132)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the root Dockerfile to include the newly added Rust workspace member packages/rs-unified-sdk-ffi in all Docker build stages that rely on enumerating workspace members, preventing cargo metadata / cargo chef failures during Docker builds.

Changes:

  • Add packages/rs-unified-sdk-ffi to the build-planner COPY --parents workspace list (needed for cargo chef prepare).
  • Add packages/rs-unified-sdk-ffi to the build-drive-abci, build-js, and build-rs-dapi source COPY --parents blocks to keep those builds consistent with workspace membership.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@QuantumExplorer QuantumExplorer merged commit a101903 into v3.1-dev Mar 31, 2026
54 of 55 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/dockerfile-add-rs-unified-sdk-ffi branch March 31, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants