Skip to content

chore: bump rust-dashcore to commit 88e8a9aa1eadce79c8177f757f6741f8a55a83f5#3446

Merged
QuantumExplorer merged 1 commit intov3.1-devfrom
chore/bump-rust-dashcore
Apr 7, 2026
Merged

chore: bump rust-dashcore to commit 88e8a9aa1eadce79c8177f757f6741f8a55a83f5#3446
QuantumExplorer merged 1 commit intov3.1-devfrom
chore/bump-rust-dashcore

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

@ZocoLini ZocoLini commented Apr 7, 2026

Another version bump xd. This one introduces two fixes into iOS:

  • Transactions now show as pending in the UI as soon as you send the transaction without having to restart the SPVClient
  • Fixed a case where the SPVClient could get stalled

No public API modifications this time

Summary by CodeRabbit

  • Chores
    • Updated core workspace dependencies (dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-ffi, key-wallet-manager, dashcore-rpc) to newer revisions.

@github-actions github-actions bot added this to the v3.1.0 milestone Apr 7, 2026
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Apr 7, 2026

⏳ Review in progress (commit 00da809)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dba44ef4-c645-4acb-8721-314d69221c5d

📥 Commits

Reviewing files that changed from the base of the PR and between 2c00229 and 00da809.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml
✅ Files skipped from review due to trivial changes (1)
  • Cargo.toml

📝 Walkthrough

Walkthrough

The workspace dependencies in Cargo.toml were updated to pin seven Dash-related crates to a new git revision, affecting dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-ffi, key-wallet-manager, and dashcore-rpc.

Changes

Cohort / File(s) Summary
Workspace Dependency Version Bump
Cargo.toml
Updated git rev for 7 Dash-related workspace dependencies (dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-ffi, key-wallet-manager, dashcore-rpc) from dda1db7a7367... to 88e8a9aa1ead.... (+7 / -7 lines)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hopping through crates with a twitchy nose,
Seven revs updated in tidy rows.
A tiny change, a synchronized leap,
Dependencies aligned, tidy and neat.
Hooray for small wins before I nap! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating rust-dashcore dependency commits in Cargo.toml to a specific revision.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-rust-dashcore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZocoLini ZocoLini force-pushed the chore/bump-rust-dashcore branch from 2c00229 to 00da809 Compare April 7, 2026 17:27
@QuantumExplorer QuantumExplorer merged commit 1d01943 into v3.1-dev Apr 7, 2026
36 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/bump-rust-dashcore branch April 7, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants