fix(wasm-sdk): update stale default testnet DAPI node addresses

[thephez]

Issue being fixed or feature implemented

The 8 hardcoded default testnet DAPI addresses in wasm-sdk were all stale — none of the IPs appeared in the current live node list at https://quorums.testnet.networks.dash.org/masternodes. This caused js-evo-sdk connections to time out when using the default testnet configuration.

Fixes #3484

What was done?

• Replaced all 8 stale IPs in default_testnet_addresses() (packages/wasm-sdk/src/sdk.rs) with current enabled nodes from quorums.testnet.networks.dash.org/masternodes
• New addresses are distributed across the active 68.67.122.x range (port 1443) rather than using consecutive IPs

How Has This Been Tested?

• Verified new IPs against live response from https://quorums.testnet.networks.dash.org/masternodes — all selected nodes have status: ENABLED and versionCheck: success
• No test files modified; existing unit tests in wasm-sdk cover address parsing logic

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Chores
  • Updated default testnet endpoints for SDK initialization to new network addresses.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 219570e7-9deb-4b02-9f34-361733a67225

📥 Commits

Reviewing files that changed from the base of the PR and between c061bd4 and cef4216.

📒 Files selected for processing (1)

• packages/wasm-sdk/src/sdk.rs

---

📝 Walkthrough

Walkthrough

Updated the hardcoded testnet DAPI endpoint addresses in the WASM SDK by replacing eight stale IP addresses with eight active ones from the 68.67.122.x range, all on HTTPS port 1443. No functional logic or behavior was altered.

Changes

Cohort / File(s)	Summary
Testnet Configuration packages/wasm-sdk/src/sdk.rs	Replaced 8 outdated HTTPS DAPI endpoint addresses (previously unreachable) with 8 new active addresses from the 68.67.122.x range on port 1443. Updates the default testnet masternode address initialization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Eight old addresses led to nowhere fast,
But now we hop to nodes that last,
The 68.67.122 range shines so bright,
Testnet connections will be right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: updating stale default testnet DAPI node addresses in the wasm-sdk, which is the core purpose of the PR.
Linked Issues check	✅ Passed	The PR successfully addresses issue #3484 by replacing all eight stale testnet DAPI addresses with current enabled nodes from the 68.67.122.x range, resolving the timeout issue.
Out of Scope Changes check	✅ Passed	All changes are directly in-scope, limited to updating the hardcoded testnet addresses in default_testnet_addresses() function with no unrelated modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/wasm-sdk-testnet-addresses

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thepastaclaw]

✅ Review complete (commit cef4216)

[thephez]

Probably should be backported to 3.0.1 also

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (c061bd4) to head (cef4216).

Additional details and impacted files

@@            Coverage Diff            @@
##           v3.1-dev    #3485   +/-   ##
=========================================
  Coverage     84.79%   84.79%           
=========================================
  Files          2476     2476           
  Lines        267709   267709           
=========================================
+ Hits         227000   227003    +3     
+ Misses        40709    40706    -3     

Components	Coverage Δ
dpp	81.82% <ø> (+<0.01%)	⬆️
drive	84.21% <ø> (ø)
drive-abci	87.46% <ø> (ø)
sdk	∅ <ø> (∅)
dapi-client	∅ <ø> (∅)
platform-version	∅ <ø> (∅)
platform-value	92.10% <ø> (ø)
platform-wallet	∅ <ø> (∅)
drive-proof-verifier	55.66% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[thepastaclaw]

Code Review

Clean data-only change replacing 8 stale testnet DAPI addresses in wasm-sdk with current live endpoints. The wasm-sdk fix itself looks correct and low-risk. One adjacent follow-up remains: rs-sdk-ffi still ships stale hardcoded testnet defaults, so mobile clients relying on SDK defaults will keep the old timeout behavior until that path is updated too.

Reviewed commit: cef4216

🟡 1 suggestion(s)

1 additional finding

🟡 suggestion: rs-sdk-ffi still hardcodes stale testnet default addresses

packages/rs-sdk-ffi/src/sdk.rs (lines 386-393)

This PR updates the wasm-sdk defaults, but packages/rs-sdk-ffi/src/sdk.rs still uses the old hardcoded testnet address list for Network::Testnet when callers do not provide custom DAPI addresses. That means the same timeout/root-cause remains for the FFI/mobile SDK path even after this PR merges. The wasm fix is still valid on its own, but a follow-up should update the FFI defaults too so the SDKs do not drift again.

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `packages/rs-sdk-ffi/src/sdk.rs`:
- [SUGGESTION] lines 386-393: rs-sdk-ffi still hardcodes stale testnet default addresses
  This PR updates the wasm-sdk defaults, but `packages/rs-sdk-ffi/src/sdk.rs` still uses the old hardcoded testnet address list for `Network::Testnet` when callers do not provide custom DAPI addresses. That means the same timeout/root-cause remains for the FFI/mobile SDK path even after this PR merges. The wasm fix is still valid on its own, but a follow-up should update the FFI defaults too so the SDKs do not drift again.