perf(swift-sdk): gate SPV progress polling on inequality

[QuantumExplorer]

Issue being fixed or feature implemented

After leaving SwiftExampleApp running overnight the user observed it sitting at 729 MB memory and 98% CPU. Investigation traced the runaway to the 1 Hz SPV-progress polling task in PlatformWalletManager.

The poller reassigned @Published spvProgress and @Published platformAddressSyncIsSyncing on every tick regardless of whether the values had actually changed. Because PlatformSpvSyncProgress and PlatformSpvSubProgress were Sendable but not Equatable, each assignment unconditionally fired objectWillChange — forcing every observing view (the sync screens, the memory explorer, GlobalSyncIndicator) to re-evaluate body once per second forever. Over ~12 hours that's ~43,200 SwiftUI invalidations; the attribute graph and diffing caches accreted, and the loop re-emitted onto the main thread every second forever, even after sync had long settled.

What was done?

• Added Equatable conformance to PlatformSpvSubProgress and PlatformSpvSyncProgress (all members were already Equatable — just synthesised conformance).
• Gated the two @Published assignments in startProgressPolling() on inequality so identical snapshots no longer republish.
• Added a comment on the polling function explaining why the gate exists, so a future hand doesn't accidentally undo it.

The polling loop itself, its cancellation in deinit, and the FFI calls are unchanged.

How Has This Been Tested?

• xcodebuild -project SwiftExampleApp/SwiftExampleApp.xcodeproj -scheme SwiftExampleApp -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.6,arch=arm64' build succeeds.
• Manual verification of the regression itself (run overnight, watch CPU/memory) is suggested as a follow-up — the static read is already pretty conclusive but a confirmation trace would be worth banking. Instruments → Time Profiler should show the platform_wallet_manager_sync_progress stack drop out of the hot path once sync settles.

Breaking Changes

None. Equatable is an additive conformance on public types; existing call sites that didn't compare these structs continue to compile unchanged.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

Summary by CodeRabbit

• Performance
  • Optimized wallet synchronization polling to reduce redundant property updates and minimize unnecessary UI refresh cycles, improving overall app responsiveness during sync operations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 88c45451-f417-4fe7-9009-fcfc81977348

📥 Commits

Reviewing files that changed from the base of the PR and between 844edba and 78346ce.

📒 Files selected for processing (2)

• packages/swift-sdk/Sources/SwiftDashSDK/PlatformWallet/PlatformWalletManager.swift
• packages/swift-sdk/Sources/SwiftDashSDK/PlatformWallet/PlatformWalletManagerSPV.swift

---

📝 Walkthrough

Walkthrough

The changes optimize polling behavior by adding Equatable conformance to progress tracking structs and implementing conditional property updates in the polling loop. This prevents redundant SwiftUI observer re-evaluations when progress values remain unchanged between polling iterations.

Changes

Cohort / File(s)	Summary
SPV Progress Struct Conformance PlatformWalletManagerSPV.swift	Added Equatable conformance to PlatformSpvSubProgress and PlatformSpvSyncProgress structs to enable value comparison between instances.
Polling Loop Optimization PlatformWalletManager.swift	Modified startProgressPolling method to conditionally assign @Published properties (spvProgress, platformAddressSyncIsSyncing) only when newly fetched values differ from currently stored ones, eliminating redundant SwiftUI re-evaluations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A rabbit hops with joy,
No needless updates to employ,
Equatable now, we compare with care,
SwiftUI breathes lighter air! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'perf(swift-sdk): gate SPV progress polling on inequality' accurately and concisely summarizes the main performance optimization change—adding inequality checks to prevent redundant @Published property reassignments in the SPV progress polling loop.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/compassionate-bell-a57552

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thepastaclaw]

Review Gate

Commit: 78346ced

• ⏳ Debounce: 28m ago (need 30m)

• ✅ CI checks: builds passed, 0/2 tests passed

• ✅ CodeRabbit review: comment found

• ✅ Off-peak hours: off-peak (12:59 AM PT Tuesday)

• Run review now (check to override)

[github-actions]

✅ DashSDKFFI.xcframework built for this PR.

• Workflow run: https://github.com/dashpay/platform/actions/runs/25039947590
• Artifacts: DashSDKFFI.xcframework (folder), DashSDKFFI.xcframework.zip, xc_checksum.txt

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "c9c002c3def410e95ca2f5967d5d53db2bd11d9fb1491d331aaf634f2cadaa78"
)

Xcode manual integration:

• Download 'DashSDKFFI.xcframework' artifact from the run link above.
• Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
• If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

[QuantumExplorer]

Self Reviewed