Skip to content

feat(swift-example-app): collapse Platform Sync Status into compact view#3618

Merged
QuantumExplorer merged 1 commit intov3.1-devfrom
claude/pensive-taussig-8cc9ba
May 7, 2026
Merged

feat(swift-example-app): collapse Platform Sync Status into compact view#3618
QuantumExplorer merged 1 commit intov3.1-devfrom
claude/pensive-taussig-8cc9ba

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

The Platform Sync Status section in SwiftExampleApp's home view had grown to 7+ rows of detail (sync state, balance, active addresses, chain tip, checkpoint, last recent block, block time, query counters), pushing the rest of the screen below the fold. Most of those rows are diagnostic and only useful occasionally.

What was done?

Restructured the section in CoreContentView.swift so it shows a compact summary by default and tucks the rest behind a DisclosureGroup:

Always visible:

  • Sync state row (Syncing / Last sync / Not synced)
  • Platform Balance
  • Chain Tip Height (now always rendered, with placeholder before the first sync)
  • "Sync Now" / "Clear" action buttons

Behind "Show details" / "Hide details":

  • Active Addresses
  • Sync Checkpoint
  • Last Recent Block (with the existing tap-to-show-proof affordance)
  • Block Time
  • Queries Since Launch + the four QueryCountBadges (Trunk / Branch / Compacted / Recent)
  • Error display

No behavior changes — same data, same data sources, same actions. Only the default visibility changed. State is held in a new @State private var platformSyncExpanded: Bool = false.

How Has This Been Tested?

Manual review of the diff and surrounding context. I could not run xcodebuild to confirm because DashSDKFFI.xcframework is not present in this worktree (and build_ios.sh is a long, separate concern). The Swift change is self-contained — a reshuffle of an existing VStack into a DisclosureGroup plus one new @State flag — and uses only stock SwiftUI APIs already used elsewhere in the file.

Reviewers with a built framework can sanity-check by running the app and toggling the disclosure on the Core tab.

Breaking Changes

None. UI-only change in the example app.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Show Sync state, Platform Balance, and Chain Tip Height by default; move
Active Addresses, Sync Checkpoint, Last Recent Block, Block Time, query
counters, and error display behind a DisclosureGroup so the section
stops dominating the screen on the home tab.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner May 7, 2026 16:32
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@QuantumExplorer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 27 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c5b64870-c0fe-4d08-bbdf-a478afd043e1

📥 Commits

Reviewing files that changed from the base of the PR and between 8156ecc and 979c3ec.

📒 Files selected for processing (1)
  • packages/swift-sdk/SwiftExampleApp/SwiftExampleApp/Core/Views/CoreContentView.swift
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/pensive-taussig-8cc9ba

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added this to the v3.1.0 milestone May 7, 2026
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented May 7, 2026

✅ Review complete (commit 979c3ec)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "9e438722e79a2ceceff5c49b3c13434e9eb5f3fd90a22c5e59fcf58bd00d1aea"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

Copy link
Copy Markdown
Collaborator

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

I verified the checked-out PR at 979c3ec against the recorded review artifacts and the actual SwiftUI diff in packages/swift-sdk/SwiftExampleApp/SwiftExampleApp/Core/Views/CoreContentView.swift. The change is limited to presentation logic: it adds local disclosure state and moves secondary platform sync diagnostics behind a DisclosureGroup without changing sync behavior, data flow, or safety-critical logic. I did not confirm any actionable review findings.

Reviewed commit: 979c3ec

@QuantumExplorer
Copy link
Copy Markdown
Member Author

Self Reviewed

@QuantumExplorer QuantumExplorer merged commit b9ac843 into v3.1-dev May 7, 2026
16 checks passed
@QuantumExplorer QuantumExplorer deleted the claude/pensive-taussig-8cc9ba branch May 7, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants