feat(swift-example-app): collapse Platform Sync Status into compact view#3618
feat(swift-example-app): collapse Platform Sync Status into compact view#3618QuantumExplorer merged 1 commit intov3.1-devfrom
Conversation
Show Sync state, Platform Balance, and Chain Tip Height by default; move Active Addresses, Sync Checkpoint, Last Recent Block, Block Time, query counters, and error display behind a DisclosureGroup so the section stops dominating the screen on the home tab. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit 979c3ec) |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "9e438722e79a2ceceff5c49b3c13434e9eb5f3fd90a22c5e59fcf58bd00d1aea"
)Xcode manual integration:
|
There was a problem hiding this comment.
Code Review
I verified the checked-out PR at 979c3ec against the recorded review artifacts and the actual SwiftUI diff in packages/swift-sdk/SwiftExampleApp/SwiftExampleApp/Core/Views/CoreContentView.swift. The change is limited to presentation logic: it adds local disclosure state and moves secondary platform sync diagnostics behind a DisclosureGroup without changing sync behavior, data flow, or safety-critical logic. I did not confirm any actionable review findings.
Reviewed commit: 979c3ec
|
Self Reviewed |
Issue being fixed or feature implemented
The Platform Sync Status section in SwiftExampleApp's home view had grown to 7+ rows of detail (sync state, balance, active addresses, chain tip, checkpoint, last recent block, block time, query counters), pushing the rest of the screen below the fold. Most of those rows are diagnostic and only useful occasionally.
What was done?
Restructured the section in CoreContentView.swift so it shows a compact summary by default and tucks the rest behind a
DisclosureGroup:Always visible:
—placeholder before the first sync)Behind "Show details" / "Hide details":
QueryCountBadges (Trunk / Branch / Compacted / Recent)No behavior changes — same data, same data sources, same actions. Only the default visibility changed. State is held in a new
@State private var platformSyncExpanded: Bool = false.How Has This Been Tested?
Manual review of the diff and surrounding context. I could not run
xcodebuildto confirm becauseDashSDKFFI.xcframeworkis not present in this worktree (andbuild_ios.shis a long, separate concern). The Swift change is self-contained — a reshuffle of an existingVStackinto aDisclosureGroupplus one new@Stateflag — and uses only stock SwiftUI APIs already used elsewhere in the file.Reviewers with a built framework can sanity-check by running the app and toggling the disclosure on the Core tab.
Breaking Changes
None. UI-only change in the example app.
Checklist:
For repository code-owners and collaborators only