ci: bump actions/cache to v5 and codecov/codecov-action to v6#3620
ci: bump actions/cache to v5 and codecov/codecov-action to v6#3620QuantumExplorer merged 3 commits intov3.1-devfrom
Conversation
Both actions now run on Node.js 24, silencing the Node.js 20 deprecation warnings GitHub Actions emits. Mirrors dashpay/rust-dashcore#741. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request systematically upgrades GitHub Actions cache and tool dependencies across the repository. All ChangesGitHub Actions Dependency Versions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit fa9dd78) |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/swift-sdk-build.yml (1)
9-9:⚠️ Potential issue | 🟠 Major | ⚡ Quick winVerify self-hosted runner version supports
actions/cache@v5.
actions/cache@v5requires a minimum GitHub Actions runner version of 2.327.1 (uses Node.js 24 runtime). This workflow targets a[self-hosted, macOS, ARM64]runner (Line 9). Before deploying, ensure that runner is on version ≥ 2.327.1, otherwise the cache steps at lines 50, 67, and 91 will fail at runtime.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/swift-sdk-build.yml at line 9, The workflow uses a self-hosted runner (runs-on: [self-hosted, macOS, ARM64]) together with actions/cache@v5; ensure the runner's GitHub Actions runner version is >= 2.327.1 or change the workflow to use a supported cache action or hosted runner. Specifically, either (a) verify and upgrade the self-hosted runner to >= 2.327.1 so actions/cache@v5 works for the cache steps that use actions/cache@v5, or (b) pin cache steps to a compatible version (e.g., actions/cache@v4) or switch to a GitHub-hosted runner to avoid runtime failures.
🧹 Nitpick comments (2)
.github/workflows/swift-sdk-build.yml (1)
133-133: ⚡ Quick win
actions/github-script@v7uses Node.js 20, which is now deprecated — bump to v8.GitHub Actions runners will force JavaScript actions to run on Node.js 24 by default starting June 2nd, 2026, and Node.js 20 will be fully removed in September 2026. Since this PR is already systematically removing Node.js runtime deprecation warnings, bumping this reference is a natural follow-on.
♻️ Proposed fix
- uses: actions/github-script@v7 + uses: actions/github-script@v8🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/swift-sdk-build.yml at line 133, Update the GitHub Actions step that references actions/github-script@v7 to use the v8 tag to avoid Node.js 20 deprecation; locate the workflow step containing the string "uses: actions/github-script@v7" and change it to the v8 release (e.g., actions/github-script@v8) so the action runs on a supported Node.js runtime..github/actions/docker/action.yaml (1)
154-154: ⚡ Quick win
actions/github-script@v6uses Node.js 16, which is already deprecated — bump to v7 or v8.
actions/github-script@v6runs on Node.js 16, and GitHub has deprecated Node.js 16 actions and will stop supporting them. Since this PR's stated goal is to eliminate Node.js runtime deprecation warnings, this reference is a gap: it emits a deprecation warning that is older than the Node.js 20 warnings being fixed everywhere else in the PR.♻️ Proposed fix
- uses: actions/github-script@v6 + uses: actions/github-script@v7🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/actions/docker/action.yaml at line 154, The workflow currently pins the GitHub Script action to "uses: actions/github-script@v6", which targets Node.js 16 and triggers deprecation warnings; update that reference to a Node 18+ compatible release (e.g., actions/github-script@v7 or `@v8`) by replacing "actions/github-script@v6" with the chosen newer major version and verify any script inputs/behavior in the step using that action remain compatible (adjust call signature or input names in the same workflow step if needed).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/swift-sdk-build.yml:
- Line 9: The workflow uses a self-hosted runner (runs-on: [self-hosted, macOS,
ARM64]) together with actions/cache@v5; ensure the runner's GitHub Actions
runner version is >= 2.327.1 or change the workflow to use a supported cache
action or hosted runner. Specifically, either (a) verify and upgrade the
self-hosted runner to >= 2.327.1 so actions/cache@v5 works for the cache steps
that use actions/cache@v5, or (b) pin cache steps to a compatible version (e.g.,
actions/cache@v4) or switch to a GitHub-hosted runner to avoid runtime failures.
---
Nitpick comments:
In @.github/actions/docker/action.yaml:
- Line 154: The workflow currently pins the GitHub Script action to "uses:
actions/github-script@v6", which targets Node.js 16 and triggers deprecation
warnings; update that reference to a Node 18+ compatible release (e.g.,
actions/github-script@v7 or `@v8`) by replacing "actions/github-script@v6" with
the chosen newer major version and verify any script inputs/behavior in the step
using that action remain compatible (adjust call signature or input names in the
same workflow step if needed).
In @.github/workflows/swift-sdk-build.yml:
- Line 133: Update the GitHub Actions step that references
actions/github-script@v7 to use the v8 tag to avoid Node.js 20 deprecation;
locate the workflow step containing the string "uses: actions/github-script@v7"
and change it to the v8 release (e.g., actions/github-script@v8) so the action
runs on a supported Node.js runtime.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 51ef53c8-bb3e-49ee-95ac-ac47e923cd8d
📒 Files selected for processing (11)
.github/actions/docker/action.yaml.github/actions/librocksdb/action.yaml.github/actions/local-network/action.yaml.github/actions/nodejs/action.yaml.github/actions/rust/action.yaml.github/workflows/swift-example-app-ui-smoke.yml.github/workflows/swift-sdk-build.yml.github/workflows/swift-sdk-release.yml.github/workflows/tests-build-js.yml.github/workflows/tests-dashmate.yml.github/workflows/tests-rs-workspace.yml
Picks up the same Node.js 24 runtime fix for the github-script steps in the workflows/composite actions already touched by this PR (was v6/v7, both deprecated runtimes). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Pushed a8e6fcd addressing CodeRabbit's two On the major comment about runner version: the failed macOS run already pulled The |
|
Confirmed pre-existing breakage on v3.1-dev — not regression from this PR. Reproduced locally on this worktree by checking out only ``` Same three tests fail with identical errors:
Bisecting the merged commits since the last green macOS run (#3607):
The This PR (.github/* only) cannot affect Rust deserialization. Suggest tracking the dpp/rust-dashcore mismatch in a separate fix PR; this CI bump shouldn't be blocked on it. |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
I verified the checked-out merge commit fa9dd78671366d0510eaeb82ab75109a25a198cf directly rather than relying on the earlier CI-only summary. The substantive changes are in the platform-wallet persister fallback, Swift persistence callbacks, and wasm document token-payment plumbing, and I did not confirm any concrete correctness issue in the touched code. I also attempted targeted Rust validation, but workspace builds are currently blocked in this environment by tenderdash-proto trying to download Tenderdash sources with no network access; that limitation did not surface a code defect in the reviewed changes.
Reviewed commit: fa9dd78
|
Correction to my automated review summary above: the actual PR diff at |
Issue being fixed or feature implemented
GitHub Actions emits Node.js 20 deprecation warnings on every CI run because we still pin
actions/cache@v4(Node 20) andcodecov/codecov-action@v5(also pulls inactions/github-script@v7/Node 20). Mirrors dashpay/rust-dashcore#741.What was done?
actions/cache@v4(and the/save,/restoresubpaths) to@v5across the workflows in.github/workflows/and the composite actions in.github/actions/.codecov/codecov-action@v5to@v6in.github/workflows/tests-rs-workspace.yml. v6 also brings inactions/github-script@v8, removing the second deprecation notice surfaced via the codecov step.Both actions now run on Node.js 24.
How Has This Been Tested?
CI on this PR exercises every touched workflow / composite action.
Breaking Changes
None — caches keys are unchanged, so existing cache entries remain reusable.
Checklist:
For repository code-owners and collaborators only
Generated with Claude Code
Summary by CodeRabbit
Release Notes