Skip to content

chore: expand code ownership for SDK, wallet stack, proof verifier and wasm-dpp2#3840

Merged
QuantumExplorer merged 2 commits into
v3.1-devfrom
claude/peaceful-chatelet-995dac
Jun 10, 2026
Merged

chore: expand code ownership for SDK, wallet stack, proof verifier and wasm-dpp2#3840
QuantumExplorer merged 2 commits into
v3.1-devfrom
claude/peaceful-chatelet-995dac

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Jun 10, 2026

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Code-owner review is required on v3.1-dev, but ownership didn't reflect who actually works on each area, so PRs bottleneck on a single owner.

What was done?

Updated CODEOWNERS:

  • packages/swift-sdk/: added @llbartekll and @ZocoLini
  • Platform wallet stack (rs-platform-wallet, -ffi, -storage): owned by @QuantumExplorer @shumkov @lklimek @llbartekll @ZocoLini
  • packages/rs-sdk/ and packages/rs-sdk-ffi/: added @lklimek
  • packages/rs-drive-proof-verifier/: new entry — @QuantumExplorer @shumkov @lklimek
  • packages/wasm-dpp2/: new entry — @QuantumExplorer @shumkov

Because CODEOWNERS is last-match-wins, anything outside these paths still falls back to * @QuantumExplorer.

How Has This Been Tested?

N/A — CODEOWNERS-only change. Verified all added handles have write access (required for entries to take effect) and that branch protection on v3.1-dev enforces require_code_owner_reviews.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated ownership for Rust SDK packages.
    • Expanded ownership for the Swift SDK.
    • Added ownership entries for a new Platform Wallet stack (core, FFI, and storage packages).

…crates

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9d9455b5-1a73-411b-b634-19e20762ca7e

📥 Commits

Reviewing files that changed from the base of the PR and between aa919c3 and 8b750cb.

📒 Files selected for processing (1)
  • CODEOWNERS

📝 Walkthrough

Walkthrough

The CODEOWNERS file is modified to add @lklimek to Rust SDK entries, expand Swift SDK owners to include @llbartekll and @ZocoLini, and add ownership entries for the platform wallet packages (rs-platform-wallet, rs-platform-wallet-ffi, rs-platform-wallet-storage).

Changes

Ownership Assignments

Layer / File(s) Summary
Swift SDK and wallet package ownership
CODEOWNERS
Adds @lklimek to /packages/rs-sdk/ and /packages/rs-sdk-ffi/, expands /packages/swift-sdk/ owners to include @llbartekll and @ZocoLini, and inserts new ownership entries for /packages/rs-platform-wallet/, /packages/rs-platform-wallet-ffi/, and /packages/rs-platform-wallet-storage/ including @llbartekll (and @ZocoLini where shown).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I’m a rabbit in the repo bright,
Nibbling lines that set things right,
New names hop in to guard the keys,
Swift and wallets in good breeze. 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'SDK, wallet stack, proof verifier and wasm-dpp2' but the actual changes only update CODEOWNERS for SDK packages and wallet stack components, with no changes related to proof verifier or wasm-dpp2. Update the title to accurately reflect only the components actually modified, such as: 'chore: expand code ownership for SDK and platform wallet stack'
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/peaceful-chatelet-995dac

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…asm-dpp2

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@QuantumExplorer QuantumExplorer changed the title chore: add llbartekll as code owner of swift-sdk and platform wallet crates chore: expand code ownership for SDK, wallet stack, proof verifier and wasm-dpp2 Jun 10, 2026

@QuantumExplorer QuantumExplorer left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@QuantumExplorer QuantumExplorer merged commit 62933b5 into v3.1-dev Jun 10, 2026
18 of 19 checks passed
@QuantumExplorer QuantumExplorer deleted the claude/peaceful-chatelet-995dac branch June 10, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant