Skip to content

docs(swift-example-app): remove CORE-11/12/13 (not-implemented Core actions) from test plan#3919

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
claude/remove-core-11-13
Jun 16, 2026
Merged

docs(swift-example-app): remove CORE-11/12/13 (not-implemented Core actions) from test plan#3919
QuantumExplorer merged 1 commit into
v3.1-devfrom
claude/remove-core-11-13

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

CORE-11 (custom fee on transparent send), CORE-12 (CoinJoin / mixing), and CORE-13 (explicit send-via-InstantSend) are all 🚫 not implemented and not planned — custom fee isn't exposed on the transparent send path, CoinJoin isn't in the SPV crate or FFI, and InstantSend is observe-only (no user-facing send toggle). They add noise to the catalog and dashboard without being testable.

What was done?

  • Removed the three CORE-11/12/13 rows from the TEST_PLAN.md §4 catalog.
  • Removed their bullets from the "🚫 Not implemented anywhere" appendix.

The on-chain QA testCase docs for CORE-11/12/13 (dashpay QA dashboard) are deleted to match.

How Has This Been Tested?

Docs-only. No remaining references to CORE-11/12/13 in the plan; the §6 Core range shorthand is unaffected. None of the three had recorded test runs.

Breaking Changes

None (docs only).

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

🤖 Generated with Claude Code

…ctions) from test plan

CORE-11 (custom fee on transparent send), CORE-12 (CoinJoin/mixing), and
CORE-13 (explicit send-via-InstantSend) are not implemented and not planned;
drop them from the §4 catalog and the not-implemented appendix.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@QuantumExplorer, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 57 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 369d756d-47e7-42a4-8646-7af7379bd95c

📥 Commits

Reviewing files that changed from the base of the PR and between 620b80b and 3b76006.

📒 Files selected for processing (1)
  • packages/swift-sdk/SwiftExampleApp/TEST_PLAN.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/remove-core-11-13

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw

thepastaclaw commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

✅ Review complete (commit 3b76006)

@QuantumExplorer QuantumExplorer merged commit 7ee7650 into v3.1-dev Jun 16, 2026
16 checks passed
@QuantumExplorer QuantumExplorer deleted the claude/remove-core-11-13 branch June 16, 2026 16:31

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Docs-only PR removing three never-implemented test IDs (CORE-11/12/13) from the SwiftExampleApp TEST_PLAN catalog and the not-implemented appendix. Verified at head 3b76006: catalog rows now jump 10→14, no stray references to the removed IDs remain in the repo. One suggestion: the §6 Category index range CORE-01..23 still expands to the deleted IDs under the doc's own range semantics (line 342: "A-01..09 means every id in that span"). The PR description explicitly chose to leave the range unchanged, so this is a non-blocking consistency note.

🟡 1 suggestion(s)

1 additional finding(s) omitted (not in diff).

🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `packages/swift-sdk/SwiftExampleApp/TEST_PLAN.md`:
- [SUGGESTION] packages/swift-sdk/SwiftExampleApp/TEST_PLAN.md:344: Core category range still expands to removed CORE-11/12/13
  Line 342 defines the index's range shorthand as inclusive of every ID in the span ("`A-01..09` means every id in that span"). With CORE-11/12/13 rows gone from §4.1, the `CORE-01..23` shorthand here still selects three IDs that no longer exist in the catalog, which contradicts the PR goal of removing those not-planned actions. The PR description notes this was intentionally left unchanged, but per the document's own selection rules a `Category=Core` run would now reference missing test IDs. Splitting the range matches the actual catalog membership (CORE-01..10 plus the multi-wallet block CORE-14..23) and stays consistent with line 345's `MultiWallet — CORE-14..23` which already skips the deleted IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants