Skip to content

feat(dpp): AbstractConsensusError tests and extensions#670

Merged
antouhou merged 20 commits into
v0.24-devfrom
feat-public-key-validator-tests
Dec 26, 2022
Merged

feat(dpp): AbstractConsensusError tests and extensions#670
antouhou merged 20 commits into
v0.24-devfrom
feat-public-key-validator-tests

Conversation

@antouhou
Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou requested a review from shumkov as a code owner December 14, 2022 17:43
@shumkov shumkov changed the title feat: public_keys_validator.rs test feat(dpp): public_keys_validator.rs test Dec 15, 2022
qrayven
qrayven previously approved these changes Dec 15, 2022
Comment thread packages/wasm-dpp/lib/test/expect/expectError.js Outdated
@antouhou antouhou changed the title feat(dpp): public_keys_validator.rs test feat(dpp): AbstractConsensusError tests and extensions Dec 26, 2022
Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move error-specific logic in wasm-dpp/lib under errors and errors/consensus directories

Copy link
Copy Markdown
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antouhou antouhou merged commit 5372db6 into v0.24-dev Dec 26, 2022
@antouhou antouhou deleted the feat-public-key-validator-tests branch December 26, 2022 14:24
@thephez thephez added this to the v0.24.0 milestone Feb 1, 2023
QuantumExplorer added a commit that referenced this pull request May 18, 2026
PR #670 has merged to grovedb's develop branch. Point the dep at
develop's tip (e98bab5f) instead of the PR-branch SHA. Updates the
6 Cargo.toml refs + 15+ in-code/book references to the SHA.

All 3,154 drive lib tests pass. Workspace clippy with -D warnings
remains clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants