Skip to content

fix(dashmate): ZeroSSL certificates are not saved in WSL #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuplenkov merged 1 commit into from
Dec 19, 2022
Merged

fix(dashmate): ZeroSSL certificates are not saved in WSL #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/dashmate/src/listr/tasks/ssl/saveCertificateTask.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ const fs = require('fs');
const { HOME_DIR_PATH } = require('../../../constants');

/**
*
* @typedef {saveCertificateTask}
* @param {Config} config
* @return {Promise<Listr>}
* @return {Listr}
*/
async function saveCertificateTask(config) {
function saveCertificateTask(config) {
return new Listr([
{
title: 'Save certificates',
Expand Down
2 changes: 1 addition & 1 deletion packages/dashmate/src/listr/tasks/ssl/zerossl/obtainZeroSSLCertificateTaskFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function obtainZeroSSLCertificateTaskFactory(
config.set('platform.dapi.envoy.ssl.providerConfigs.zerossl.id', ctx.response.id);
config.set('platform.dapi.envoy.ssl.provider', 'zerossl');

await saveCertificateTask(config);
return saveCertificateTask(config);
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/dashmate/src/listr/tasks/ssl/zerossl/renewZeroSSLCertificateTaskFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function renewZeroSSLCertificateTaskFactory(
task: async (ctx) => {
config.set('platform.dapi.envoy.ssl.providerConfigs.zerossl.id', ctx.response.id);

await saveCertificateTask(config);
return saveCertificateTask(config);
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/dashmate/src/ssl/zerossl/downloadCertificate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const wait = require('../../util/wait');
* @typedef {downloadCertificate}
* @param {string} id
* @param {string} apiKey
* @returns {string}
* @returns {Promise<string>}
*/
async function downloadCertificate(id, apiKey) {
const maxTime = 10 * 60 * 1000; // 10 minutes
Expand Down