Skip to content

fix: Starcounter-Jack JSON-Patch Prototype Pollution vulnerability #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
Jan 5, 2023
Merged

fix: Starcounter-Jack JSON-Patch Prototype Pollution vulnerability #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 6 additions & 21 deletions .pnp.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file removed .yarn/cache/fast-deep-equal-npm-2.0.1-9c01e08a62-b701835a87.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/fast-json-patch-npm-2.2.1-63b021bb37-955aebb3f8.zip
View file
Open in desktop
Binary file not shown.
Binary file removed .yarn/cache/fast-json-patch-npm-3.1.0-f4bd467b5f-bad25a6121.zip
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/cache/fast-json-patch-npm-3.1.1-7e8bb70a45-c4525b61b2.zip
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"elliptic": "^6.5.4",
"bn.js": "4.12.0",
"ejs": "^3.1.7",
"fast-json-patch": "^3.1.1",
Copy link
Copy Markdown
Collaborator

@shumkov shumkov Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only updated dependency version is not enough? Resolution usually needed if you have deep dependency problem which you can't control

Copy link
Copy Markdown
Collaborator Author

@strophy strophy Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a resolution

Copy link
Copy Markdown
Collaborator

@shumkov shumkov Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but just updating version in DPP packages not enough?

Copy link
Copy Markdown
Collaborator Author

@strophy strophy Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you are asking or what change you are proposing. The change is in the monorepo root package.json because this is the only legal location for resolutions.

"oclif@3.4.2": "patch:oclif@npm:3.4.2#.yarn/patches/oclif-npm-3.4.2-a655d32eed.patch",
"qs": "^6.7.3",
"engine.io": "^6.2.1"
Expand Down
4 changes: 2 additions & 2 deletions packages/dashmate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@
"globby": "^11",
"mocha": "^9.1.2",
"mocha-sinon": "^2.1.2",
"oclif": "^3.4.2",
"sinon": "^11.1.2",
"sinon-chai": "^3.7.0",
"oclif": "^3.4.2"
"sinon-chai": "^3.7.0"
},
"files": [
"bin",
Expand Down
2 changes: 1 addition & 1 deletion packages/js-dpp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"bls-signatures": "^0.2.5",
"bs58": "^4.0.1",
"cbor": "^8.0.0",
"fast-json-patch": "^3.1.0",
"fast-json-patch": "^3.1.1",
"json-schema-diff-validator": "^0.4.1",
"json-schema-traverse": "^1.0.0",
"lodash": "^4.17.21",
Expand Down
2 changes: 1 addition & 1 deletion packages/wasm-dpp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"eslint-config-airbnb-base": "^14.2.1",
"eslint-plugin-import": "^2.24.2",
"events": "^3.3.0",
"fast-json-patch": "^3.1.0",
"fast-json-patch": "^3.1.1",
"https-browserify": "^1.0.0",
"json-schema-diff-validator": "^0.4.1",
"karma": "^6.4.1",
Expand Down
28 changes: 6 additions & 22 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,7 +1590,7 @@ __metadata:
eslint-config-airbnb-base: ^14.2.1
eslint-plugin-import: ^2.24.2
events: ^3.3.0
fast-json-patch: ^3.1.0
fast-json-patch: ^3.1.1
https-browserify: ^1.0.0
json-schema-diff-validator: ^0.4.1
json-schema-traverse: ^1.0.0
Expand Down Expand Up @@ -1932,7 +1932,7 @@ __metadata:
eslint-config-airbnb-base: ^14.2.1
eslint-plugin-import: ^2.24.2
events: ^3.3.0
fast-json-patch: ^3.1.0
fast-json-patch: ^3.1.1
https-browserify: ^1.0.0
json-schema-diff-validator: ^0.4.1
karma: ^6.4.1
Expand Down Expand Up @@ -6924,13 +6924,6 @@ __metadata:
languageName: node
linkType: hard

"fast-deep-equal@npm:^2.0.1":
version: 2.0.1
resolution: "fast-deep-equal@npm:2.0.1"
checksum: b701835a87985e0ec4925bdf1f0c1e7eb56309b5d12d534d5b4b69d95a54d65bb16861c081781ead55f73f12d6c60ba668713391ee7fbf6b0567026f579b7b0b
languageName: node
linkType: hard

"fast-deep-equal@npm:^3.1.1, fast-deep-equal@npm:^3.1.3":
version: 3.1.3
resolution: "fast-deep-equal@npm:3.1.3"
Expand All @@ -6951,19 +6944,10 @@ __metadata:
languageName: node
linkType: hard

"fast-json-patch@npm:^2.0.5":
version: 2.2.1
resolution: "fast-json-patch@npm:2.2.1"
dependencies:
fast-deep-equal: ^2.0.1
checksum: 955aebb3f873d1fb0452a5d8c34865ce4c3c6cdafeb7d3ad98d43b467de9a5a0d304132f8595fd2b373f8f4d200605947e865286b180f3a55e8377a634893164
languageName: node
linkType: hard

"fast-json-patch@npm:^3.1.0":
version: 3.1.0
resolution: "fast-json-patch@npm:3.1.0"
checksum: bad25a6121650d5e138fba787f8e8c6c738779a9a84a978513261110632b1450d96b92a7fedd17188ae847cd5a2b0560725b400a0214aefd3c6506e1be36c66e
"fast-json-patch@npm:^3.1.1":
version: 3.1.1
resolution: "fast-json-patch@npm:3.1.1"
checksum: c4525b61b2471df60d4b025b4118b036d99778a93431aa44d1084218182841d82ce93056f0f3bbd731a24e6a8e69820128adf1873eb2199a26c62ef58d137833
languageName: node
linkType: hard

Expand Down