Skip to content

feat(wasm-dpp): provide external entropy generator to document factory#845

Merged
markin-io merged 4 commits intov0.24-devfrom
feat/wasm-dpp/provide-external-entropy-generator-to-document-factory
Mar 23, 2023
Merged

feat(wasm-dpp): provide external entropy generator to document factory#845
markin-io merged 4 commits intov0.24-devfrom
feat/wasm-dpp/provide-external-entropy-generator-to-document-factory

Conversation

@markin-io
Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

PR addresses next issues:

  • Need to provide external entropy generator to Document Factory (needed for JS)
  • Proper error handling for entropy generator (need to know what's going on in case external generator fails to produce entropy)

What was done?

  • Return Result instead of panicking in generate() function
  • Add entropy generator as an argument to DocumentFactory
  • Refactor entropy generator file structure
  • Update JS fixture

How Has This Been Tested?

  • CI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io added this to the v0.24.0 milestone Mar 22, 2023
Copy link
Copy Markdown
Contributor

@antouhou antouhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all good, except I'd use a generic instead of dyn Box

@markin-io markin-io force-pushed the feat/wasm-dpp/provide-external-entropy-generator-to-document-factory branch from 3ace226 to f22a878 Compare March 23, 2023 09:26
@markin-io
Copy link
Copy Markdown
Contributor Author

Agreed to refactor Box<dyn EntropyGenerator> in a separate ticket

@markin-io markin-io merged commit 566533d into v0.24-dev Mar 23, 2023
@markin-io markin-io deleted the feat/wasm-dpp/provide-external-entropy-generator-to-document-factory branch March 23, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants