feat(ffi): implement Display trait for NetworkInfo and remove to_string method

[PastaPastaPasta]

• Added implementation of the fmt::Display trait for NetworkInfo to provide a formatted string representation of the network.
• Removed the redundant to_string method, streamlining the API and improving consistency in how network information is presented.

Summary by CodeRabbit

• Refactor
  • Network information now uses a unified formatting method for display across the app.
  • Removed a redundant string-based representation pathway.

[coderabbitai]

Walkthrough

Replaces NetworkInfo’s public to_string method with a fmt::Display implementation that delegates formatting to the underlying DashNetwork. Adds use of fmt to support Display. No other logic changes.

Changes

Cohort / File(s)	Change summary
API surface update (Display over to_string) dash-network-ffi/src/lib.rs	Removed pub fn to_string(&self) -> String from impl NetworkInfo. Implemented fmt::Display for NetworkInfo, delegating to self.network.fmt(f). Added use fmt import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at fmt’s new grace,
No more to_string in this place—
Display now speaks with cleaner cheer,
Delegation crisp and clear.
Hop-hop! The network’s lines align,
Rusty carrots, code divine. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title accurately summarizes the main change by stating the implementation of the Display trait for NetworkInfo and the removal of the to_string method, matching the pull request objectives and code modifications. It is concise, follows conventional commit formatting, and avoids unnecessary details, making the primary change immediately obvious to reviewers.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/clippy-trivial-to-string

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26f5008 and ec0fa5a.

📒 Files selected for processing (1)

• dash-network-ffi/src/lib.rs (2 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.rs: Use proper error types with thiserror and propagate errors appropriately
Use the tokio runtime for async operations in Rust
Use conditional compilation feature flags for optional features (#[cfg(feature = ...)])
Format Rust code with cargo fmt (and enforce via cargo fmt --check)
Run clippy with -D warnings and fix all lints
Adhere to MSRV Rust 1.89 (avoid features requiring newer compiler)

**/*.rs: Format Rust code with rustfmt (per rustfmt.toml); run cargo fmt --all before commits
Lint with clippy; treat warnings as errors in CI
Follow Rust naming: snake_case for functions/variables, UpperCamelCase for types/traits, SCREAMING_SNAKE_CASE for consts
Prefer async using tokio where applicable

Files:

• dash-network-ffi/src/lib.rs

{dash-network-ffi,dash-spv-ffi,key-wallet-ffi,swift-dash-core-sdk}/**/*.{rs,c,h,swift}

📄 CodeRabbit inference engine (CLAUDE.md)

Be careful with memory management at FFI boundaries (C/Swift interop)

Files:

• dash-network-ffi/src/lib.rs

**/src/**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

**/src/**/*.rs: Each crate keeps sources in src/
Avoid unwrap()/expect() in library code; use proper error types (e.g., thiserror)
Place unit tests alongside code with #[cfg(test)]

Files:

• dash-network-ffi/src/lib.rs

*-ffi/**

📄 CodeRabbit inference engine (AGENTS.md)

FFI bindings live in *-ffi crates

Files:

• dash-network-ffi/src/lib.rs

🧠 Learnings (1)

📚 Learning: 2025-08-29T04:00:14.154Z

Learnt from: CR
PR: dashpay/rust-dashcore#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-29T04:00:14.154Z
Learning: Applies to {dash-network-ffi,dash-spv-ffi,key-wallet-ffi,swift-dash-core-sdk}/**/*.{rs,c,h,swift} : Be careful with memory management at FFI boundaries (C/Swift interop)

Applied to files:

• dash-network-ffi/src/lib.rs

🧬 Code graph analysis (1)

dash-network-ffi/src/lib.rs (1)

dash-network/src/lib.rs (1)

• fmt (87-94)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)

• GitHub Check: RPC Tests (stable, true)
• GitHub Check: Integration Tests (stable, 22.1.3)
• GitHub Check: Core Components Tests
• GitHub Check: fuzz (dash_deserialize_address)
• GitHub Check: fuzz (hashes_json)
• GitHub Check: SPV Components Tests
• GitHub Check: fuzz (hashes_sha1)
• GitHub Check: fuzz (hashes_cbor)
• GitHub Check: fuzz (dash_deserialize_block)
• GitHub Check: fuzz (hashes_sha256)
• GitHub Check: fuzz (hashes_sha512)
• GitHub Check: fuzz (dash_deser_net_msg)
• GitHub Check: fuzz (dash_script_bytes_to_asm_fmt)
• GitHub Check: fuzz (dash_deserialize_script)
• GitHub Check: fuzz (hashes_ripemd160)
• GitHub Check: fuzz (hashes_sha512_256)
• GitHub Check: fuzz (dash_deserialize_witness)
• GitHub Check: fuzz (dash_deserialize_amount)

🔇 Additional comments (2)

dash-network-ffi/src/lib.rs (2)

3-4: Scoped fmt import is appropriate

Importing std::fmt locally keeps the intent clear and avoids pulling broader prelude traits unnecessarily. Nicely done.

---

84-87: No lingering UFCS calls to NetworkInfo::to_string found
Search for NetworkInfo::to_string returned no matches; safe to proceed with the Display impl and removal of the inherent method.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}