Skip to content

chore: update docs of Network entries#499

Draft
xdustinface wants to merge 2 commits intorefactor/dash-networkfrom
chore/fix-network-docs
Draft

chore: update docs of Network entries#499
xdustinface wants to merge 2 commits intorefactor/dash-networkfrom
chore/fix-network-docs

Conversation

@xdustinface
Copy link
Collaborator

Get rid of the "Bitcoin" and improve the others a bit.

Based on:

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b42ab0cc-16a1-4580-afef-1abe9b72238c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-network-docs

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 98.59155% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.99%. Comparing base (f74c43e) to head (b8a8fc5).
⚠️ Report is 1 commits behind head on refactor/dash-network.

Files with missing lines Patch % Lines
dash/src/network/constants.rs 98.43% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           refactor/dash-network     #499      +/-   ##
=========================================================
+ Coverage                  63.05%   63.99%   +0.94%     
=========================================================
  Files                        313      313              
  Lines                      64878    64914      +36     
=========================================================
+ Hits                       40907    41540     +633     
+ Misses                     23971    23374     -597     
Flag Coverage Δ *Carryforward flag
core 74.93% <98.59%> (+0.03%) ⬆️
dash-network 74.91% <ø> (+0.01%) ⬆️ Carriedforward from 1ac4908
dash-network-ffi 34.74% <ø> (ø) Carriedforward from 1ac4908
dash-spv 68.18% <ø> (ø) Carriedforward from 1ac4908
dash-spv-ffi 34.74% <ø> (ø) Carriedforward from 1ac4908
dashcore 74.91% <ø> (+0.01%) ⬆️ Carriedforward from 1ac4908
dashcore-private 74.91% <ø> (+0.01%) ⬆️ Carriedforward from 1ac4908
dashcore-rpc 19.92% <ø> (ø) Carriedforward from 1ac4908
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from 1ac4908
dashcore_hashes 74.91% <ø> (+0.01%) ⬆️ Carriedforward from 1ac4908
ffi 33.53% <ø> (-1.22%) ⬇️
key-wallet 65.58% <ø> (ø) Carriedforward from 1ac4908
key-wallet-ffi 34.74% <ø> (ø) Carriedforward from 1ac4908
key-wallet-manager 65.58% <ø> (ø) Carriedforward from 1ac4908
rpc 19.92% <ø> (ø)
spv 68.18% <ø> (ø)
wallet 65.58% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
dash-spv/src/client/lifecycle.rs 55.28% <ø> (ø)
dash-spv/src/sync/masternodes/manager.rs 41.04% <ø> (ø)
dash/src/address.rs 52.95% <ø> (+0.21%) ⬆️
dash/src/blockdata/constants.rs 100.00% <ø> (+0.64%) ⬆️
dash/src/blockdata/transaction/mod.rs 86.15% <ø> (ø)
dash/src/consensus/params.rs 0.00% <ø> (ø)
dash/src/crypto/key.rs 76.33% <ø> (+0.13%) ⬆️
dash/src/crypto/sighash.rs 65.27% <ø> (ø)
dash/src/sml/llmq_type/mod.rs 62.38% <ø> (ø)
dash/src/sml/llmq_type/network.rs 70.29% <ø> (+3.31%) ⬆️
... and 10 more

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZocoLini ZocoLini force-pushed the refactor/dash-network branch from 1ac4908 to 68e7a7d Compare March 9, 2026 15:40
@github-actions github-actions bot added the merge-conflict The PR conflicts with the target branch. label Mar 9, 2026
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR conflicts with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants