Skip to content

refactor(key-wallet-ffi): remove and replaced FFIExtendedPrivateKey with FFIExtendedPrivKey#645

Merged
QuantumExplorer merged 1 commit intov0.42-devfrom
refactor/remove-FFIExtendedPrivateKey
Apr 14, 2026
Merged

refactor(key-wallet-ffi): remove and replaced FFIExtendedPrivateKey with FFIExtendedPrivKey#645
QuantumExplorer merged 1 commit intov0.42-devfrom
refactor/remove-FFIExtendedPrivateKey

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

@ZocoLini ZocoLini commented Apr 13, 2026

so, for some reason, we have twice the same structure but with slightly different name and this was causing issues when trying to recover some old tests that are out of scope right now

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

Warning

Rate limit exceeded

@ZocoLini has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 8 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 51 minutes and 8 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fb8386ce-0ab1-4be2-87c5-6c7f1c62c2af

📥 Commits

Reviewing files that changed from the base of the PR and between 383b306 and 3198461.

📒 Files selected for processing (4)
  • key-wallet-ffi/FFI_API.md
  • key-wallet-ffi/src/account_derivation.rs
  • key-wallet-ffi/src/derivation.rs
  • key-wallet-ffi/src/keys.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remove-FFIExtendedPrivateKey

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.86%. Comparing base (383b306) to head (3198461).
⚠️ Report is 2 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
key-wallet-ffi/src/account_derivation.rs 0.00% 9 Missing ⚠️
key-wallet-ffi/src/keys.rs 16.66% 5 Missing ⚠️
key-wallet-ffi/src/derivation.rs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #645      +/-   ##
=============================================
+ Coverage      67.48%   67.86%   +0.38%     
=============================================
  Files            246      318      +72     
  Lines          49280    67780   +18500     
=============================================
+ Hits           33256    46001   +12745     
- Misses         16024    21779    +5755     
Flag Coverage Δ
core 75.21% <ø> (ø)
ffi 38.81% <10.52%> (+2.42%) ⬆️
rpc 20.00% <ø> (ø)
spv 85.31% <ø> (-0.08%) ⬇️
wallet 67.56% <ø> (?)
Files with missing lines Coverage Δ
key-wallet-ffi/src/derivation.rs 25.98% <25.00%> (+12.58%) ⬆️
key-wallet-ffi/src/keys.rs 13.28% <16.66%> (+8.34%) ⬆️
key-wallet-ffi/src/account_derivation.rs 0.00% <0.00%> (ø)

... and 91 files with indirect coverage changes

@QuantumExplorer QuantumExplorer merged commit 2089aaa into v0.42-dev Apr 14, 2026
38 checks passed
@QuantumExplorer QuantumExplorer deleted the refactor/remove-FFIExtendedPrivateKey branch April 14, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants