Skip to content

feat(key-wallet-ffi): add value and address fields to OutputDetail and FFIOutputDetail#647

Closed
ZocoLini wants to merge 1 commit intov0.42-devfrom
feat/output-detail-more-details
Closed

feat(key-wallet-ffi): add value and address fields to OutputDetail and FFIOutputDetail#647
ZocoLini wants to merge 1 commit intov0.42-devfrom
feat/output-detail-more-details

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

Warning

Rate limit exceeded

@ZocoLini has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 6 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 6 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d2ddfb5f-e841-4aeb-af45-a300680a52de

📥 Commits

Reviewing files that changed from the base of the PR and between 2089aaa and 5751a5e.

📒 Files selected for processing (5)
  • dash-spv-ffi/src/callbacks.rs
  • key-wallet-ffi/src/managed_account.rs
  • key-wallet-ffi/src/types.rs
  • key-wallet/src/managed_account/mod.rs
  • key-wallet/src/managed_account/transaction_record.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/output-detail-more-details

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZocoLini ZocoLini requested a review from xdustinface April 14, 2026 18:54
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.78%. Comparing base (2089aaa) to head (5751a5e).

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #647      +/-   ##
=============================================
- Coverage      68.08%   67.78%   -0.31%     
=============================================
  Files            318      318              
  Lines          67800    67828      +28     
=============================================
- Hits           46164    45978     -186     
- Misses         21636    21850     +214     
Flag Coverage Δ
core 75.21% <ø> (ø)
ffi 38.10% <100.00%> (-2.01%) ⬇️
rpc 20.00% <ø> (ø)
spv 85.41% <ø> (+0.07%) ⬆️
wallet 67.62% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
dash-spv-ffi/src/callbacks.rs 79.76% <100.00%> (+5.97%) ⬆️
key-wallet-ffi/src/managed_account.rs 51.00% <100.00%> (-2.09%) ⬇️
key-wallet-ffi/src/types.rs 78.67% <100.00%> (+0.26%) ⬆️
key-wallet/src/managed_account/mod.rs 54.22% <100.00%> (+0.21%) ⬆️
...y-wallet/src/managed_account/transaction_record.rs 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

@ZocoLini
Copy link
Copy Markdown
Collaborator Author

ZocoLini commented Apr 14, 2026

done here #640

@ZocoLini ZocoLini closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant