Skip to content

refactor(key-wallet-ffi): new more ergonomic FFIError implementation #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZocoLini wants to merge 1 commit into
base: v0.42-dev
Choose a base branch
from

new more ergonomic FFIError implementation

f091181
Select commit
Loading
Failed to load commit list.
Open

refactor(key-wallet-ffi): new more ergonomic FFIError implementation #670

new more ergonomic FFIError implementation
f091181
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 21, 2026 in 0s

69.73% (+1.34%) compared to ee1ebd9

View this Pull Request on Codecov

69.73% (+1.34%) compared to ee1ebd9

Details

Codecov Report

❌ Patch coverage is 44.54913% with 412 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.73%. Comparing base (ee1ebd9) to head (f091181).

Files with missing lines Patch % Lines
key-wallet-ffi/src/account_derivation.rs 20.87% 72 Missing ⚠️
key-wallet-ffi/src/keys.rs 16.45% 66 Missing ⚠️
key-wallet-ffi/src/managed_wallet.rs 16.17% 57 Missing ⚠️
key-wallet-ffi/src/transaction.rs 0.00% 56 Missing ⚠️
key-wallet-ffi/src/derivation.rs 34.48% 38 Missing ⚠️
key-wallet-ffi/src/address_pool.rs 14.63% 35 Missing ⚠️
key-wallet-ffi/src/wallet_manager.rs 71.05% 22 Missing ⚠️
key-wallet-ffi/src/transaction_checking.rs 0.00% 15 Missing ⚠️
key-wallet-ffi/src/error.rs 91.47% 11 Missing ⚠️
key-wallet-ffi/src/mnemonic.rs 67.64% 11 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #670      +/-   ##
=============================================
+ Coverage      68.39%   69.73%   +1.34%     
=============================================
  Files            320      320              
  Lines          68023    66641    -1382     
=============================================
- Hits           46524    46472      -52     
+ Misses         21499    20169    -1330
Files with missing lines Coverage Δ
key-wallet-ffi/src/account.rs 21.17% <100.00%> (+0.02%) ⬆️
key-wallet-ffi/src/account_collection.rs 56.97% <100.00%> (+5.16%) ⬆️
key-wallet-ffi/src/utxo.rs 91.58% <100.00%> (+12.82%) ⬆️
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% <0.00%> (ø)
key-wallet-ffi/src/address.rs 79.54% <84.61%> (+64.65%) ⬆️
key-wallet-ffi/src/managed_account_collection.rs 21.52% <0.00%> (-15.74%) ⬇️
key-wallet-ffi/src/managed_account.rs 54.08% <53.84%> (+1.45%) ⬆️
key-wallet-ffi/src/bip38.rs 0.00% <0.00%> (ø)
key-wallet-ffi/src/wallet.rs 15.00% <64.28%> (-1.13%) ⬇️
key-wallet-ffi/src/error.rs 90.64% <91.47%> (+0.64%) ⬆️
... and 9 more

... and 5 files with indirect coverage changes

View more details on Codecov