Skip to content

refactor: rename wallet heights to reflect their meaning better #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdustinface merged 2 commits into from
Apr 24, 2026

refactor(wallet): rename filter_committed_height to synced_height

ceb349f
Select commit
Loading
Failed to load commit list.
Merged

refactor: rename wallet heights to reflect their meaning better #683

refactor(wallet): rename filter_committed_height to synced_height
ceb349f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 24, 2026 in 1s

70.15% (-0.26%) compared to 62d7af7

View this Pull Request on Codecov

70.15% (-0.26%) compared to 62d7af7

Details

Codecov Report

❌ Patch coverage is 69.33333% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.15%. Comparing base (62d7af7) to head (ceb349f).
⚠️ Report is 3 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
key-wallet-manager/src/process_block.rs 71.42% 6 Missing ⚠️
...allet/managed_wallet_info/wallet_info_interface.rs 53.84% 6 Missing ⚠️
key-wallet-manager/src/wallet_interface.rs 0.00% 5 Missing ⚠️
key-wallet-ffi/src/managed_wallet.rs 0.00% 2 Missing ⚠️
key-wallet-manager/src/lib.rs 60.00% 2 Missing ⚠️
key-wallet-ffi/src/transaction.rs 0.00% 1 Missing ⚠️
key-wallet-ffi/src/utxo.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #683      +/-   ##
=============================================
- Coverage      70.40%   70.15%   -0.26%     
=============================================
  Files            247      319      +72     
  Lines          48029    66692   +18663     
=============================================
+ Hits           33816    46789   +12973     
- Misses         14213    19903    +5690
Files with missing lines Coverage Δ
dash-spv/src/sync/blocks/manager.rs 94.69% <100.00%> (ø)
dash-spv/src/sync/filters/manager.rs 96.65% <100.00%> (-0.30%) ⬇️
key-wallet-ffi/src/wallet_manager.rs 69.39% <100.00%> (+0.60%) ⬆️
key-wallet/src/managed_account/mod.rs 55.05% <100.00%> (ø)
...-wallet/src/transaction_checking/wallet_checker.rs 99.28% <100.00%> (ø)
...c/wallet/managed_wallet_info/asset_lock_builder.rs 79.57% <100.00%> (ø)
key-wallet-ffi/src/transaction.rs 0.00% <0.00%> (ø)
key-wallet-ffi/src/utxo.rs 56.07% <0.00%> (-35.52%) ⬇️
key-wallet-ffi/src/managed_wallet.rs 60.10% <0.00%> (+1.44%) ⬆️
key-wallet-manager/src/lib.rs 61.18% <60.00%> (ø)
... and 3 more

... and 89 files with indirect coverage changes

View more details on Codecov