Skip to content

feat(key-wallet): expose instant_send_locks accessor on ManagedWalletInfo#712

Merged
QuantumExplorer merged 1 commit intov0.42-devfrom
expose-instant-send-locks-accessor
May 3, 2026
Merged

feat(key-wallet): expose instant_send_locks accessor on ManagedWalletInfo#712
QuantumExplorer merged 1 commit intov0.42-devfrom
expose-instant-send-locks-accessor

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

Summary

  • Adds a read-only instant_send_locks() -> &HashSet<Txid> getter on ManagedWalletInfo.
  • The underlying field is pub(crate) and #[serde(skip)]; this accessor lets external diagnostic surfaces (e.g. the iOS memory explorer) enumerate IS-locked txids without relaxing the mutation boundary.

Test plan

  • cargo build -p key-wallet
  • cargo test -p key-wallet
  • Confirm consumer (iOS memory explorer) can list IS-locked txids via the new accessor

🤖 Generated with Claude Code

…letInfo`

Adds a read-only `instant_send_locks()` getter so external diagnostic
surfaces (e.g. the iOS memory explorer) can list the txids that have
received an IS-lock without bypassing the `pub(crate)` mutation
boundary on the field.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 3, 2026

Warning

Rate limit exceeded

@QuantumExplorer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 32 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b889462a-aaf3-49cc-9af5-f8e169d86652

📥 Commits

Reviewing files that changed from the base of the PR and between ca507a9 and e3ea5cc.

📒 Files selected for processing (1)
  • key-wallet/src/wallet/managed_wallet_info/mod.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch expose-instant-send-locks-accessor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 32 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer QuantumExplorer merged commit 5603fff into v0.42-dev May 3, 2026
33 checks passed
@QuantumExplorer QuantumExplorer deleted the expose-instant-send-locks-accessor branch May 3, 2026 15:54
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.57%. Comparing base (ca507a9) to head (e3ea5cc).
⚠️ Report is 1 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
key-wallet/src/wallet/managed_wallet_info/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #712      +/-   ##
=============================================
- Coverage      70.58%   70.57%   -0.01%     
=============================================
  Files            320      320              
  Lines          68243    68246       +3     
=============================================
- Hits           48168    48164       -4     
- Misses         20075    20082       +7     
Flag Coverage Δ
core 75.81% <ø> (ø)
ffi 43.37% <ø> (ø)
rpc 20.00% <ø> (ø)
spv 87.22% <ø> (-0.03%) ⬇️
wallet 69.62% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
key-wallet/src/wallet/managed_wallet_info/mod.rs 70.00% <0.00%> (-3.69%) ⬇️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant