Skip to content

chore: clone bls library if tenderdash is not tracked by git#355

Merged
shotonoff merged 1 commit intov0.7-devfrom
issue-351-add-sync-git-submodules-in-makefile
Apr 22, 2022
Merged

chore: clone bls library if tenderdash is not tracked by git#355
shotonoff merged 1 commit intov0.7-devfrom
issue-351-add-sync-git-submodules-in-makefile

Conversation

@shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Apr 21, 2022

Issue being fixed or feature implemented

What was done?

if the tenderdash source code is not tracked by git then:

  • Display a message about fallback scenario
  • Clone "develop_0.1" single branch to be able to build a project

How Has This Been Tested?

Build the project locally from archive

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

…ng "develop_0.1" branch as fallback scenario to build a project
@shotonoff shotonoff changed the title chore: if the tenderdash source code is not tracked by git then cloning "develop_0.1" branch as fallback scenario to build a project chore: clone bls library if tenderdash is not tracked by git Apr 21, 2022
@shotonoff shotonoff requested a review from lklimek April 21, 2022 15:48
@shotonoff shotonoff self-assigned this Apr 21, 2022
Copy link
Collaborator

@lklimek lklimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shotonoff shotonoff merged commit beae958 into v0.7-dev Apr 22, 2022
@shotonoff shotonoff deleted the issue-351-add-sync-git-submodules-in-makefile branch April 22, 2022 10:10
shotonoff added a commit that referenced this pull request Apr 22, 2022
* Update golangci-lint-action and golang-ci versions.

Also specify Go toolchain version in actions (now required).

(cherry picked from commit 14461339f43029e1cfedf799fa8a60ffcf1f5b69)

* fix(consensus): network stuck due to outdated proposal block (#327)

* fix(consensus): network stuck due to outdated proposal block

* refactor(consensus): cleanup  TestStateProposalTime

* fix(xchacha20poly1305_test): (*testing.common).Errorf does not support error-wrapping directive %w

* fix(consensus): fix race condition

* chore(consensus): apply peer review feedback

* fix: don't process WAL logs for old rounds (#331)

* feat: add the implementation of WAL iterator with a feature skipping messages till the final round

* feat: change order and name of walIter fields

* feat: stop iterating if reader returns error

* feat: remove checking on allowed message types

* feat: improve was_iter_test.go

* refactor: modify by go-lint feedback

* refactor: remove useless expected length

* chore: disable lint for a non-critical line in a test

* chore(release): update changelog and bump version to 0.7.1-dev.1 (#330)

* chore(release): update changelog generation config

* chore(release): update changelog and version to 0.7.1-dev.1

* build(release): implement full release workflow in the release script (#332) (#345)

* chore(release): update changelog generation config

* build(release): improve version release script

* feat(release): release script now creates GitHub release

* Update golangci-lint-action and golang-ci versions.

Also specify Go toolchain version in actions (now required).

(cherry picked from commit 14461339f43029e1cfedf799fa8a60ffcf1f5b69)

* fix(consensus): network stuck due to outdated proposal block (#327)

* fix(consensus): network stuck due to outdated proposal block

* refactor(consensus): cleanup  TestStateProposalTime

* fix(xchacha20poly1305_test): (*testing.common).Errorf does not support error-wrapping directive %w

* fix(consensus): fix race condition

* chore(consensus): apply peer review feedback

* fix: don't process WAL logs for old rounds (#331)

* feat: add the implementation of WAL iterator with a feature skipping messages till the final round

* feat: change order and name of walIter fields

* feat: stop iterating if reader returns error

* feat: remove checking on allowed message types

* feat: improve was_iter_test.go

* refactor: modify by go-lint feedback

* refactor: remove useless expected length

* chore: disable lint for a non-critical line in a test

* chore(release): update changelog and bump version to 0.7.1-dev.1 (#330)

* chore(release): update changelog generation config

* chore(release): update changelog and version to 0.7.1-dev.1

* build(release): implement full release workflow in the release script (#332) (#345)

* chore(release): update changelog generation config

* build(release): improve version release script

* feat(release): release script now creates GitHub release

* chore(release): update changelog and version to 0.7.1

* chore: if the tenderdash source code is not tracked by git then cloning "develop_0.1" branch as fallback scenario to build a project (#355)

* fix: remove duplicate method BlockID

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
lklimek added a commit that referenced this pull request Dec 6, 2022
* Update golangci-lint-action and golang-ci versions.

Also specify Go toolchain version in actions (now required).

(cherry picked from commit 14461339f43029e1cfedf799fa8a60ffcf1f5b69)

* fix(consensus): network stuck due to outdated proposal block (#327)

* fix(consensus): network stuck due to outdated proposal block

* refactor(consensus): cleanup  TestStateProposalTime

* fix(xchacha20poly1305_test): (*testing.common).Errorf does not support error-wrapping directive %w

* fix(consensus): fix race condition

* chore(consensus): apply peer review feedback

* fix: don't process WAL logs for old rounds (#331)

* feat: add the implementation of WAL iterator with a feature skipping messages till the final round

* feat: change order and name of walIter fields

* feat: stop iterating if reader returns error

* feat: remove checking on allowed message types

* feat: improve was_iter_test.go

* refactor: modify by go-lint feedback

* refactor: remove useless expected length

* chore: disable lint for a non-critical line in a test

* chore(release): update changelog and bump version to 0.7.1-dev.1 (#330)

* chore(release): update changelog generation config

* chore(release): update changelog and version to 0.7.1-dev.1

* build(release): implement full release workflow in the release script (#332) (#345)

* chore(release): update changelog generation config

* build(release): improve version release script

* feat(release): release script now creates GitHub release

* Update golangci-lint-action and golang-ci versions.

Also specify Go toolchain version in actions (now required).

(cherry picked from commit 14461339f43029e1cfedf799fa8a60ffcf1f5b69)

* fix(consensus): network stuck due to outdated proposal block (#327)

* fix(consensus): network stuck due to outdated proposal block

* refactor(consensus): cleanup  TestStateProposalTime

* fix(xchacha20poly1305_test): (*testing.common).Errorf does not support error-wrapping directive %w

* fix(consensus): fix race condition

* chore(consensus): apply peer review feedback

* fix: don't process WAL logs for old rounds (#331)

* feat: add the implementation of WAL iterator with a feature skipping messages till the final round

* feat: change order and name of walIter fields

* feat: stop iterating if reader returns error

* feat: remove checking on allowed message types

* feat: improve was_iter_test.go

* refactor: modify by go-lint feedback

* refactor: remove useless expected length

* chore: disable lint for a non-critical line in a test

* chore(release): update changelog and bump version to 0.7.1-dev.1 (#330)

* chore(release): update changelog generation config

* chore(release): update changelog and version to 0.7.1-dev.1

* build(release): implement full release workflow in the release script (#332) (#345)

* chore(release): update changelog generation config

* build(release): improve version release script

* feat(release): release script now creates GitHub release

* chore(release): update changelog and version to 0.7.1

* chore: if the tenderdash source code is not tracked by git then cloning "develop_0.1" branch as fallback scenario to build a project (#355)

* feat(scripts): abci protocol parser

* feat(scripts): abci protocol parser - packet capture

Added "abcidump capture" function that captures and decodes ABCI
communication over TCP connection.

* feat(abcidump): parse CBOR messages

* doc(abcidump): abcidump documentation

* chore(abcidump): Cleanup during self-review

* fix(test): fix dependencies in e2e tests

* refactor(abcidump): refactor cbor and apply review feedback

* refactor(abcidump): move abcidump from scripts/ to cmd/

* test(abcidump): add cbor test

* test(abcidump): add parse cmd test

* test(abcidump): test parser NewMessageType

* test(abcidump): test parser

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: Dmitrii Golubev <shotonoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants