Skip to content

chore: update abci++ spec#414

Merged
shotonoff merged 6 commits intov0.9-devfrom
TD-85-update-abci++-spec
Sep 1, 2022
Merged

chore: update abci++ spec#414
shotonoff merged 6 commits intov0.9-devfrom
TD-85-update-abci++-spec

Conversation

@shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Jul 11, 2022

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shotonoff shotonoff force-pushed the TD-85-update-abci++-spec branch from 29113b2 to 9f2125e Compare July 11, 2022 11:57
@shotonoff shotonoff force-pushed the TD-85-update-abci++-spec branch from 9f2125e to 1b7196f Compare July 12, 2022 08:33
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jul 23, 2022
Copy link
Contributor

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions

@github-actions github-actions bot removed the Stale label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Aug 7, 2022
@github-actions github-actions bot removed the Stale label Aug 10, 2022
@shotonoff shotonoff changed the base branch from v0.8-dev to v0.9-dev August 15, 2022 14:17
shotonoff and others added 3 commits August 15, 2022 16:18
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
@shotonoff shotonoff requested a review from thephez August 15, 2022 14:19
Copy link
Collaborator Author

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thephez thank you for your suggestions, all accepted

Copy link
Contributor

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also an indenting issue preventing those 2 tables from rendering.

shotonoff and others added 2 commits August 19, 2022 14:55
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
@shotonoff shotonoff requested a review from thephez August 19, 2022 12:55
Copy link
Collaborator Author

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thephez suggested accepted

@shotonoff shotonoff merged commit 6dd4bcc into v0.9-dev Sep 1, 2022
@shotonoff shotonoff deleted the TD-85-update-abci++-spec branch September 1, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants