Merged
Conversation
…ck.SetDashParams method
…oncept-same-block-execution
…oncept-same-block-execution
…oncept-same-block-execution
…-tx-hash-into-context
…oncept-same-block-execution
shotonoff
force-pushed
the
proof-of-concept-same-block-execution
branch
from
6d5d6ca to
f02c4c2
Compare
lklimek
reviewed
Jul 20, 2022
internal/state/validation.go
Outdated
Collaborator
There was a problem hiding this comment.
maybe we should store state.PreviousAppHash ?
internal/state/validation.go
Outdated
Collaborator
There was a problem hiding this comment.
Maybe we should compare with current validators?
internal/state/dash.go
Outdated
| } | ||
| } | ||
|
|
||
| func updateStatConsensusParams( |
Collaborator
There was a problem hiding this comment.
Suggested change
| func updateStatConsensusParams( | |
| func updateStateConsensusParams( |
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
…ution' into proof-of-concept-same-block-execution
* feat!(kvstore): same-block-execution KV store * fix(kvstore): dstIter not closed correctly
…451) * fix: some fixes and refactoring for stabilizing same-block execution * refactor: merge kvstore.App with kvstore.Application and remove kvstore_v2.go * fix: kvstore_test.go * fix: TestValUpdates * fix: TestValUpdates * fix: TestKVStore * fix: rpc/client tests * fix: make stable some tests affected by kvstore refactoring * fix: update uncommitted state if a validator out of quorum set and a node has proposal block for the height * Update internal/consensus/replay_test.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * refactor: changes according to PR feedback * fix: blocking wal_test.go because of default context * fix: code style issues * fix: abci-cli test * fix: typo in struct name CurentRoundState => CurrentRoundState * fix: a few data race issues * fix: TestHandshakeReplayNone * fix: ValidatorUpdate.MarshalJSON * fix: ValidatorUpdate.UnmarshalJSON * chore(e2e): prototype e2e test app for same-block execution * fix(consensus): state is nil on genesis * fix(state): invalid stateID height on genesis * chore: improve logging * Update abci/tests/server/client.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * Update abci/tests/server/client.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * Update internal/proxy/client_test.go Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> * refactor: changes according to PR feedback Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Base automatically changed from
populate-node-pro-tx-hash-into-context
to
v0.9-dev
September 8, 2022 08:14
shotonoff
changed the title
lklimek
approved these changes
Sep 9, 2022
lklimek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only