refactor(ci): enable building docker for develop branch#443
refactor(ci): enable building docker for develop branch#443
Conversation
…instead of genesis last-block-time
fix: don't use genesis last-block-time for a height is equal initial-height
chore(release): update changelog and bump version to 0.8.0-dev.7
chore(release): update changelog and bump version to 0.8.0-dev.8
chore: update alpine image version
.github/workflows/docker.yml
Outdated
| - published | ||
| push: | ||
| branches: | ||
| - v0.*-dev |
There was a problem hiding this comment.
Did you consiider building an image of each PR that has some label?
Like, we'll add a label "build-docker-image" to the PR, and it will build and push the image to registry with every push to that PR.
That will be better for our needs, as we will be able to request images for non-merged PRs.
See https://blog.mergify.com/running-github-actions-only-on-certain-pull-requests/ (just googled, didn't check).
There was a problem hiding this comment.
Another option could be to add a workflow_dispatch trigger, so you can run the action by clicking a button, selecting a branch and typing an arbitrary docker tag in the GitHub Actions UI. This is what we went with for core team here. Up to you guys :)
There was a problem hiding this comment.
I think we can use both options :-)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
3 participants
Issue being fixed or feature implemented
Enable building docker image for develop branches
What was done?
Changed github ci configuration to create a tag based on branch name.
How Has This Been Tested?
Manually
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only