Skip to content

feat: allow create-proof-block-range to be 0#444

Merged
shotonoff merged 2 commits intov0.8-devfrom
allow-set-zero-for-create-proof-block-range-parameter
Aug 16, 2022
Merged

feat: allow create-proof-block-range to be 0#444
shotonoff merged 2 commits intov0.8-devfrom
allow-set-zero-for-create-proof-block-range-parameter

Conversation

@shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Aug 16, 2022

Issue being fixed or feature implemented

Drive team requested to add the ability to disable proof block operation

What was done?

Change validation 'create-proof-block-range', allow to set 0 to ignore proof block app hash

How Has This Been Tested?

e2e tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shotonoff shotonoff changed the title refactor: allow set 0 for 'create-proof-block-range' to ignore proof … refactor: change validation 'create-proof-block-range' paramter Aug 16, 2022
@shotonoff shotonoff changed the title refactor: change validation 'create-proof-block-range' paramter refactor: change validation 'create-proof-block-range' parameter Aug 16, 2022
@shumkov shumkov changed the title refactor: change validation 'create-proof-block-range' parameter feat: allow create-proof-block-range to be 0 Aug 16, 2022
Copy link
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shotonoff shotonoff merged commit 4fa2ce0 into v0.8-dev Aug 16, 2022
@shotonoff shotonoff deleted the allow-set-zero-for-create-proof-block-range-parameter branch August 16, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants