Skip to content

refactor: publish block events after block commit#459

Merged
shotonoff merged 3 commits intov0.10-devfrom
refactor-fire-events
Sep 16, 2022
Merged

refactor: publish block events after block commit#459
shotonoff merged 3 commits intov0.10-devfrom
refactor-fire-events

Conversation

@shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Sep 13, 2022

Issue being fixed or feature implemented

What was done?

Function fireEvents was split into two phases: 1) creation events and 2) publishing its
Now EventSet is responsible for this functionality

How Has This Been Tested?

Tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shotonoff shotonoff merged commit 0ee15d6 into v0.10-dev Sep 16, 2022
@shotonoff shotonoff deleted the refactor-fire-events branch September 16, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants