refactor: handshake block-replay mechanism#460
Merged
Conversation
shotonoff
changed the title
shotonoff
changed the title
lklimek
requested changes
Sep 16, 2022
5 tasks
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
shotonoff
commented
Sep 19, 2022
Collaborator
Author
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
made changes by feedback
lklimek
approved these changes
Sep 20, 2022
| wantNBlocks: 1, | ||
| }, | ||
| { | ||
| // tenderdash state at the initial height, replayer does InitChain call to get initial-state form the app |
Collaborator
There was a problem hiding this comment.
See #461 (comment) for some test scenarios to consider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Block replay mechanism was written as a few long functions that complicates reading and supporting.
What was done?
HandshakeHow Has This Been Tested?
Tests
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only