fix(consensus): TestReactorValidatorSetChanges#468
Merged
Conversation
As we add a tx to each block as part of vote extension logic, we break other tests.
* refactor: remove commit ABCI call
…d return error, refactor state store
This reverts commit a8cd027.
shotonoff
changed the title
lklimek
reviewed
Oct 3, 2022
lklimek
approved these changes
Oct 3, 2022
shotonoff
changed the title
lklimek
approved these changes
Oct 4, 2022
abci/example/kvstore/kvstore.go
Outdated
| } | ||
|
|
||
| func (app *Application) ProcessProposal(_ context.Context, req *abci.RequestProcessProposal) (*abci.ResponseProcessProposal, error) { | ||
| app.mu.Lock() |
Collaborator
Author
There was a problem hiding this comment.
because of merge, by chance
abci/example/kvstore/kvstore.go
Outdated
|
|
||
| // CheckTX implements ABCI | ||
| func (app *Application) CheckTx(_ context.Context, req *abci.RequestCheckTx) (*abci.ResponseCheckTx, error) { | ||
| app.mu.Lock() |
Collaborator
Author
There was a problem hiding this comment.
because of merge, by chance
shotonoff
commented
Oct 4, 2022
Collaborator
Author
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
revert mutex usage to ProcessProposal, CheckTx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
After implementation same-block execution the test
TestReactorValidatorSetChangesbecame a flaky, we have to eliminate this behaviour to ensure that the code base is stableWhat was done?
The main goal of this PR is to fix flaky behaviour of
TestReactorValidatorSetChangesunit test,along with this was added a few minor changes which should simplify the code base
How Has This Been Tested?
Unit test
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only