Skip to content

Test: add deadlock detection with go-deadlock#471

Merged
lklimek merged 6 commits intov0.10-devfrom
test-with-go-deadlock
Nov 28, 2022
Merged

Test: add deadlock detection with go-deadlock#471
lklimek merged 6 commits intov0.10-devfrom
test-with-go-deadlock

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Oct 5, 2022

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Oct 22, 2022
@github-actions github-actions bot closed this Oct 27, 2022
@lklimek lklimek reopened this Nov 28, 2022
@lklimek lklimek force-pushed the test-with-go-deadlock branch from a615cdd to bcb75dc Compare November 28, 2022 14:05
@lklimek lklimek removed the Stale label Nov 28, 2022
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments

fmt.Println("POTENTIAL DEADLOCK DETECTED")
fmt.Println("===========================")
}
sync.Opts.DeadlockTimeout = 2 * time.Minute
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think to reduce this to 1 min?

@lklimek lklimek merged commit 1f7aba5 into v0.10-dev Nov 28, 2022
@lklimek lklimek deleted the test-with-go-deadlock branch November 28, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants