Conversation
lklimek
reviewed
Oct 20, 2022
abci/example/kvstore/snapshots.go
Outdated
| } | ||
| } | ||
|
|
||
| func (s *offerSnapshot) reset() { |
Collaborator
There was a problem hiding this comment.
func (*offerSnapshot).reset is unused (unused)
| nodeMetrics.consensus.BlockSyncing.Set(1) | ||
| } | ||
|
|
||
| if cfg.P2P.PexReactor { |
Collaborator
There was a problem hiding this comment.
Why this condition was removed?
If it's by purpose, did you also remove corresponding config code and config example?
Collaborator
Author
There was a problem hiding this comment.
we don't have other behaviour, PEX must be only P2P.
regarding your question: I decided to separate these changes. next changes should remove this parameter from config.
Collaborator
|
Please change PR title to sth that will go into changelog. |
shotonoff
commented
Oct 20, 2022
| nodeMetrics.consensus.BlockSyncing.Set(1) | ||
| } | ||
|
|
||
| if cfg.P2P.PexReactor { |
Collaborator
Author
There was a problem hiding this comment.
we don't have other behaviour, PEX must be only P2P.
regarding your question: I decided to separate these changes. next changes should remove this parameter from config.
lklimek
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Despite the
dashcoree2e network configuration being stable, therotatenetwork configuration does not work, it needs to find out the root cause and fix it.What was done?
runWithPeerMutexis acquired a lock that is redundant and not necessary, because it doesn't modify a p2p router state. removing this method eliminates the deadlock.abci/example/kvstore/snapshots.gokvstore.Application.getValidatorSetUpdateconfig.P2P.PexReactorflag to use p2p PEX reactor. it is not required, because tenderdash supports only one implementation pex reactor.How Has This Been Tested?
Unit tests / E2E tests
Breaking Changes
Checklist:
For repository code-owners and collaborators only