fix(kvstore): abci Info() returns invalid height at genesis#474
Merged
fix(kvstore): abci Info() returns invalid height at genesis#474
Conversation
Co-authored-by: Dmitrii Golubev <shotonoff@gmail.com>
shotonoff
approved these changes
Oct 21, 2022
| // GetHeight returns height of the state | ||
| GetHeight() int64 | ||
| // IncrementHeight increments height by 1 | ||
| // IncrementHeight increments height by 1, but not lower than initial height. |
Collaborator
There was a problem hiding this comment.
if I understand correctly, we never can be lower because we only grow
Collaborator
Author
There was a problem hiding this comment.
If height == 0 and initialHeight == 1000, then IncrementHeight() sets height to 1000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
For initial (genesis) height 1000, Example kvstore (used in tests) returns 999 in response to Info() call.
What was done?
Info() will return 0 for initial height.
Internally, kvstore.State stores height 0 if we are at genesis. It also stores InitialHeight and uses it to increment from 0 directly to InitialHeight(), as needed.
How Has This Been Tested?
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only