Skip to content

feat(kvstore): consensus params updates support#475

Merged
lklimek merged 2 commits intov0.10-devfrom
sbe-fix-todos
Oct 12, 2022
Merged

feat(kvstore): consensus params updates support#475
lklimek merged 2 commits intov0.10-devfrom
sbe-fix-todos

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Oct 7, 2022

Issue being fixed or feature implemented

kvstore after rewrite didn't support setting core chain locks to be returned to Tenderdash.

What was done?

Implemented core chain height in a similar way to validator set updates.

How Has This Been Tested?

added unit tests.

Breaking Changes

none

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as draft October 7, 2022 14:41
@lklimek lklimek marked this pull request as ready for review October 10, 2022 15:23
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lklimek lklimek merged commit ad0b4ca into v0.10-dev Oct 12, 2022
@lklimek lklimek deleted the sbe-fix-todos branch October 12, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants