refactor: change a logic of usage CoreChainLockHeight#485
Merged
refactor: change a logic of usage CoreChainLockHeight#485
Conversation
…repareProposal.CoreChainLockedHeight
…rocessProposal.CoreChainLockedHeight
…ay of storing of ABCI response state in CurrentRoundState
lklimek
requested changes
Oct 19, 2022
| tendermint.types.CoreChainLock core_chain_lock_update = 100; | ||
| // Changes to validator set (set voting power to 0 to remove). | ||
| ValidatorSetUpdate validator_set_update = 101 [(gogoproto.nullable) = true]; | ||
| ValidatorSetUpdate validator_set_update = 100 [(gogoproto.nullable) = true]; |
Collaborator
There was a problem hiding this comment.
Please regenerate API docs with make proto-doc
internal/state/dash.go
Outdated
| state State, | ||
| updateProviders ...UpdateProvider) ([]UpdateFunc, error) { | ||
| updates := []UpdateFunc{} | ||
| func PrepareStateUpdates(updateProviders ...UpdateProvider) ([]UpdateFunc, error) { |
Collaborator
There was a problem hiding this comment.
IMO this approach is obsolete and should be deprecated/removed. We don't need this anymore, as this logic is done by CurrentRoundState.
lklimek
approved these changes
Oct 19, 2022
shotonoff
commented
Oct 19, 2022
Collaborator
Author
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
please have a look at the answers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The changes in this PR are requested by Protocol team, which were encountered during integration of same-block execution approach.
What was done?
RequestPrepareProposal.CoreChainLockedHeightmust useLastCoreChainLockedBlockHeightfrom the stateCoreChainLockUpdatetoProposalstruct. The value must be consumed fromResponsePrepareProposal.CoreChainLockUpdateProposal.CoreChainLockUpdatecoreChainLockthrough querying ABCI invalidateBlockChainLockfunction. The verification will be implemented on Drive side.How Has This Been Tested?
unit and e2e tests
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only