Conversation
Collaborator
|
Is it ok that this field doesn't participate in any tests? |
lklimek
approved these changes
Oct 20, 2022
| message ResponseCheckTx { | ||
| uint32 code = 1; | ||
| bytes data = 2; | ||
| string info = 4; // nondeterministic |
Collaborator
There was a problem hiding this comment.
As we generate docs from *.proto files, please add/move documentation comments from the spec .md to .proto when you touch some struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Apparently since the last backport was missed ResponseCheckTx.Info field, that is necessary for ABCI
What was done?
ResponseCheckTx.InfotoResultBroadcastTx.InfoHow Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only