feat: add core_chain_lock_update to RequestProcessProposal#492
Merged
feat: add core_chain_lock_update to RequestProcessProposal#492
Conversation
lklimek
reviewed
Oct 26, 2022
shotonoff
commented
Nov 2, 2022
Collaborator
Author
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
answered on the question
lklimek
requested changes
Nov 2, 2022
Collaborator
lklimek
left a comment
lklimek
left a comment
There was a problem hiding this comment.
Please add / improve some test to cover this change
shotonoff
commented
Nov 2, 2022
Collaborator
Author
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
updated TestProcessProposal
lklimek
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
These changes requested by Drive team. it is required for verification next core-chain-lock in ABCI.
What was done?
Added
core_chain_lock_updatefield toRequestProcessProposalHow Has This Been Tested?
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only