feat(abci)!: put full block in RequestFinalizeBlock #505
Merged
feat(abci)!: put full block in RequestFinalizeBlock #505
Conversation
lklimek
approved these changes
Nov 17, 2022
Collaborator
lklimek
left a comment
lklimek
left a comment
There was a problem hiding this comment.
LGTM, some minor things:
- Title of PR - maybe sth like:
feat(abci)!: put full block in RequestFinalizeBlock- this is the most significant change - Please review linter comments.
shotonoff
changed the title
shotonoff
commented
Nov 17, 2022
Collaborator
Author
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
applied suggestions and answered on questions
shumkov
approved these changes
Nov 18, 2022
Collaborator
shumkov
left a comment
shumkov
left a comment
There was a problem hiding this comment.
Proto looks good to me. Thank you.
shotonoff
deleted the
td-129-support-commit-on-finalize-block-in-kvstore
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Need to add block commit verification to kvstore on finalize block
Add whole bock to
RequestFinalizeBlockinstead of several fields from itsWhat was done?
RequestFinalizeBlockHow Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only