Skip to content

fix(e2e): catchup round number is not correct#507

Merged
lklimek merged 14 commits intov0.10-devfrom
e2e-fix-app
Nov 21, 2022
Merged

fix(e2e): catchup round number is not correct#507
lklimek merged 14 commits intov0.10-devfrom
e2e-fix-app

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Nov 17, 2022

Issue being fixed or feature implemented

Nodes sending proposal block parts for catchup loads them from the store.
Unfortunately, stored information didn't contain the round number, causing block part verification to fail when it belonged to any round different than 0.

Also, two other issues were detected and fixed:

  • CurrentRoundState wasn't correctly initialized when the round changed
  • e2e app didn't process correctly initial height different than 1

What was done?

  • added round to BlockMeta
  • ensure cs.RoundState.CurrentRoundState is reset when round changes
  • e2e app: disabled height verification when at genesis

How Has This Been Tested?

  • passed e2e tests
  • passed unit tests

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the v0.10.0 milestone Nov 21, 2022
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

@lklimek lklimek merged commit e7aa633 into v0.10-dev Nov 21, 2022
@lklimek lklimek deleted the e2e-fix-app branch November 21, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants