Conversation
This reverts commit 02452f1.
lklimek
changed the title
shotonoff
previously approved these changes
Dec 13, 2022
Collaborator
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
LGTM: left a few questions
shotonoff
added a commit
that referenced
this pull request
Dec 15, 2022
* chore(types)!: rename genesis.json quorum fields (#515) * fix(consensus): ProcessProposal executed twice for a block (#516) * fix(consensus): ProcessProposal executed twice for a block * fix(consensus): ensure process proposal is called once before finalize block * fix(consensus): ensure ProcessProposal is called at least once for a block * build(deps): Bump actions/setup-go from 3.3.1 to 3.4.0 (#524) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3.3.1 to 3.4.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v3.3.1...v3.4.0) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): Bump bufbuild/buf-setup-action from 1.9.0 to 1.10.0 (#525) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(consensus): proposer-based timestamp broken during backport (#523) * fix(consensus): proposer-based timestamp is broken * fix(consensus): initial block time must be equal genesis time * test(consensus): update TestStateProposalTime for PBTS * test(consensus): fix TestStateLock_POLSafety2 for PBTS * Revert "test(consensus): skip broken PBTS tests (#500)" This reverts commit 02452f1. * refactor(time): simplify time processing * feat(log): Allow definition of log assertions in TestingLogger * test(consensus): refactor PBTS tests * chore(log): replace TestingLogger interface with struct * chore(state): move block time logic to separate fn * chore(abci)!: remove Snapshot.core_chain_locked_height (#527) * chore(abci)!: remove Snapshot.core_chain_locked_height * build: bump Golang to 1.19 * fix(wal): improve wal replay mechanism (#510) * refactor: improve wal iterator * feat: add config parameter to turn on/off skipping the WAL rounds to the last * refactor: clean up code * refactor: add TestWALRoundsSkipper * fix: derive a commit from vote-set during replay * fix: add validators priority incrementing to select proper proposer * chore(release): update changelog and version to 0.10.0-dev.6 (#526) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Proposer-based timestamp logic was not backported correctly from upstream, and it conflicted with Tenderdash own implementation
What was done?
Reviewed tendermint PR and backported relevant logic.
How Has This Been Tested?
Re-enabled tests in pbts_test.go.
Breaking Changes
none
Checklist:
For repository code-owners and collaborators only