Skip to content

fix(p2p): decrease log verbosity by logging send/recv logs on trace level#533

Merged
lklimek merged 1 commit intov0.10-devfrom
log-trace-level
Dec 16, 2022
Merged

fix(p2p): decrease log verbosity by logging send/recv logs on trace level#533
lklimek merged 1 commit intov0.10-devfrom
log-trace-level

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Dec 16, 2022

Issue being fixed or feature implemented

In debug logs, all exchanged messages are logged, causing way too much logs to be generated.

This is hard to use during debugging, and hard to manage on a daily basis.

What was done?

Moved these logs from level.Debug to level.Trace.

How Has This Been Tested?

  • Github workflow passed.
  • Run e2e test locally with log_level = "trace" and log_level = "debug" and compared the results

Result: 679 of 859 log lines got "TRACE" level, what means DEBUG level logs will take ~ 20% of previous space.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title chore(p2p): decrease log verbosity by logging send/recv logs on trace level fix(p2p): decrease log verbosity by logging send/recv logs on trace level Dec 16, 2022
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lklimek lklimek merged commit 265abf3 into v0.10-dev Dec 16, 2022
@lklimek lklimek deleted the log-trace-level branch December 16, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants