Skip to content

build: enable deadlock detection on -dev docker images #540

Merged
lklimek merged 14 commits intov0.10-devfrom
build-with-deadlock-detection
Jan 3, 2023
Merged

build: enable deadlock detection on -dev docker images #540
lklimek merged 14 commits intov0.10-devfrom
build-with-deadlock-detection

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Dec 22, 2022

Issue being fixed or feature implemented

On devnets, we want to have deadlock detection enabled in order to detect and fix deadlock events.

Also, bls build scripts refer to non-existing branch develop_0.1 of https://github.com/dashpay/bls-signatures.git.

What was done?

  • configured Dockerfile to accept TENDERMINT_BUILD_OPTIONS=deadlock
  • configured docker.yml Github action to determine build type (final/dev) and set TENDERMINT_BUILD_OPTIONS=deadlock on dev builds
  • added "--verbose" flag to tenderdash version to display deadlock detection status
  • improved bls build script to checkout correct commit from shotonoff/bls repo (temporary)

How Has This Been Tested?

  1. Built image locally both with and with, checked tenderdash version --verbose to see deadlock detection support status:
docker buildx build -f DOCKER/Dockerfile --build-arg TENDERMINT_BUILD_OPTIONS=deadlock --tag tenderdash:test .
docker run -ti --rm   tenderdash:test   version --verbose

0.10.0-dev.7
Go version: go1.19.3
Deadlock detection: enabled, timeout:  5m0s

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek force-pushed the build-with-deadlock-detection branch from 0e83004 to 9c9b10e Compare December 22, 2022 14:05
@lklimek lklimek marked this pull request as ready for review December 22, 2022 14:15
shotonoff
shotonoff previously approved these changes Dec 22, 2022
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jan 2, 2023
@lklimek lklimek removed the Stale label Jan 2, 2023
shotonoff
shotonoff previously approved these changes Jan 3, 2023
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if caching is needed and can increase an image building in github CI

@lklimek lklimek requested a review from shotonoff January 3, 2023 11:36
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lklimek lklimek merged commit 604fbf3 into v0.10-dev Jan 3, 2023
@lklimek lklimek deleted the build-with-deadlock-detection branch January 3, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants