Skip to content

fix: flaky TestReactor_Backfill test#549

Merged
shotonoff merged 3 commits intov0.10-devfrom
td-136-fix-flaky-test-reactor_backfill
Jan 5, 2023
Merged

fix: flaky TestReactor_Backfill test#549
shotonoff merged 3 commits intov0.10-devfrom
td-136-fix-flaky-test-reactor_backfill

Conversation

@shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Jan 4, 2023

Issue being fixed or feature implemented

Need to fix flaky TestReactor_Backfill test

What was done?

  • refactored TestReactor_Backfill test
  • appends peerID to peer-list only if a resulted light-block is not nil

How Has This Been Tested?

Unit-test

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek
lklimek previously approved these changes Jan 5, 2023
@shotonoff shotonoff merged commit 6229591 into v0.10-dev Jan 5, 2023
@shotonoff shotonoff deleted the td-136-fix-flaky-test-reactor_backfill branch January 5, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants