Skip to content

build(docker): add abcidump to release image#563

Merged
lklimek merged 1 commit intov0.10-devfrom
build-abci
Jan 26, 2023
Merged

build(docker): add abcidump to release image#563
lklimek merged 1 commit intov0.10-devfrom
build-abci

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Jan 26, 2023

Issue being fixed or feature implemented

abcidump is a tool that can be used to debug communication between Tenderdash and ABCI client (Drive).
Injecting it into the docker image is quite complex, so we decided to include it in the image.

What was done?

Install libpcap inside the docker image
Build and install abcidump to /usr/bin/abcidump

How Has This Been Tested?

Built locally with

docker buildx build -f DOCKER/Dockerfile --build-arg TENDERMINT_BUILD_OPTIONS=deadlock --tag tenderdash:test .

Built with Github pipeline: https://github.com/dashpay/tenderdash/actions/runs/4013973095

Tested with:

docker run -ti --entrypoint /usr/bin/abcidump tenderdash:test help
docker run -ti --entrypoint /usr/bin/abcidump dashpay/tenderdash:build-abci --help

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title build: add abcidump to release image build(docker): add abcidump to release image Jan 26, 2023
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lklimek lklimek merged commit 86ff007 into v0.10-dev Jan 26, 2023
@lklimek lklimek deleted the build-abci branch January 26, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants