feat(cmd): conversion of PEM-encoded ED25519 node keys#564
Merged
feat(cmd): conversion of PEM-encoded ED25519 node keys#564
Conversation
shotonoff
reviewed
Feb 1, 2023
Collaborator
shotonoff
left a comment
There was a problem hiding this comment.
please, have a look at the questions/comments/suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
For various key management processes it is useful to be able to use existing ED25519 keys as Tenderdash node keys.
Various tools, like OpenSSL, generate keys in PEM format.
PEM keys need to be converted in order to use in Tenderdash, which uses its own (JSON) key storage format.
What was done?
tenderdash gen-node-keywas extended by adding additional flag, --from-pem:How Has This Been Tested?
Using OpenSSL, generated ED25519 private key:
Generated node ID for this private key:
Used provided privkey.pem to generate Tenderdash keys, and compare node ID with the one in
idfield:Breaking Changes
None
Checklist:
For repository code-owners and collaborators only