fix(config)!: quorum type set to 0 during replay at genesis#570
Merged
fix(config)!: quorum type set to 0 during replay at genesis#570
Conversation
lklimek
force-pushed
the
llmq-quorum-types
branch
4 times, most recently
from
fc54584 to
d421cff
Compare
lklimek
force-pushed
the
llmq-quorum-types
branch
from
fde43d8 to
b969d2d
Compare
lklimek
changed the title
lklimek
changed the title
shotonoff
approved these changes
Feb 7, 2023
Collaborator
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
LGTM
left one minor suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
When a validator is restarted before committing new block, quorum type is set to 0.
What was done?
quorum-typefrom config, we rely on genesis onetraceIn future, we can consider moving quorum type to consensus params.
How Has This Been Tested?
github actions, devnet
Breaking Changes
quorum-typeis deprecated and not used.validator_quorum_typein genesis doc is required.Checklist:
For repository code-owners and collaborators only