Skip to content

build(docker): improve docker image build caching#571

Merged
lklimek merged 11 commits intov0.10-devfrom
build/docker-cache
Feb 9, 2023
Merged

build(docker): improve docker image build caching#571
lklimek merged 11 commits intov0.10-devfrom
build/docker-cache

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Feb 3, 2023

Issue being fixed or feature implemented

Docker image build takes ~ 30 minutes, making it hard to work with when debugging.

What was done?

  • push "base" build image with dependencies and BLS library prebuilt to Docker Hub, as dashpay/tenderdash:buildcache-deps
  • use make build-binary to avoid rebuilding BLS
  • make "docker tag" optional
  • optimized size of cached layers

How Has This Been Tested?

Run actions, got down to 17 mins from ~30 mins earlier. Majority of this time is ARM64 build.

Example run: https://github.com/dashpay/tenderdash/actions/runs/4132517467

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek force-pushed the build/docker-cache branch from 0699e72 to 2f1e0c7 Compare February 3, 2023 17:15
@lklimek lklimek force-pushed the build/docker-cache branch from 01c8dd0 to b302bf9 Compare February 8, 2023 14:21
@lklimek lklimek marked this pull request as ready for review February 9, 2023 09:20
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lklimek lklimek merged commit 5de8929 into v0.10-dev Feb 9, 2023
@lklimek lklimek deleted the build/docker-cache branch February 9, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants