test(factory): refactor genesis doc generation#573
Merged
Conversation
lklimek
force-pushed
the
refactor-tests-genesis
branch
from
259cdf2 to
c73871e
Compare
lklimek
force-pushed
the
refactor-tests-genesis
branch
from
a16ee79 to
c9fff9a
Compare
shotonoff
previously approved these changes
Feb 10, 2023
Collaborator
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
left a coupe of minor questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Genesis doc generation is a bit too complex, for example, factory.RandGenesisDoc() requires unnecessary arguments and duplicates code.
What was done?
How Has This Been Tested?
Github Actions
Breaking Changes
none
Checklist:
For repository code-owners and collaborators only