fix(pex): seed doesn't respond to pex requests#574
Merged
Conversation
44d9bc5 to
ead9533
Compare
shotonoff
previously approved these changes
Feb 10, 2023
Collaborator
shotonoff
left a comment
There was a problem hiding this comment.
LGTM
left one question
6639657 to
b2847d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
On a devnet with > 10 masternodes, seed fails to advertise addresses in response to PexRequest.
This is caused by a combination of several factors:
What was done?
peerManage.storedirectlyHow Has This Been Tested?
Tested on devnet, by providing a Docker image and ensuring the issue cannot be reproduced anymore.
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only