fix(build): docker tag is invalid for empty input.tag#580
Merged
Conversation
2ab4788 to
f1f7762
Compare
shotonoff
added a commit
that referenced
this pull request
Feb 15, 2023
shotonoff
added a commit
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Docker build fails due to invalid docker image tag generated:
https://github.com/dashpay/tenderdash/actions/runs/4144431646
ERROR: invalid tag "dashpay/tenderdash:-dev": invalid reference format
What was done?
added
enable=to respective line.How Has This Been Tested?
Started Docker action manually, with and without tag, and verified the output.
With input tag:
without input tag:
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only