Skip to content

fix(build): docker tag is invalid for empty input.tag#580

Merged
lklimek merged 1 commit intov0.10-devfrom
fix-docker-tag
Feb 10, 2023
Merged

fix(build): docker tag is invalid for empty input.tag#580
lklimek merged 1 commit intov0.10-devfrom
fix-docker-tag

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Feb 10, 2023

Issue being fixed or feature implemented

Docker build fails due to invalid docker image tag generated:

https://github.com/dashpay/tenderdash/actions/runs/4144431646

ERROR: invalid tag "dashpay/tenderdash:-dev": invalid reference format

What was done?

added enable= to respective line.

How Has This Been Tested?

Started Docker action manually, with and without tag, and verified the output.

With input tag:

Processing tags input
  type=semver,pattern={{version}},value=test,enable=true,priority=900
  type=match,pattern=v(\d+),group=1,value=,enable=true,priority=800
  type=match,pattern=v(\d+.\d+),group=1,value=,enable=true,priority=800
  type=match,pattern=v(\d+.\d+.\d+),group=1,value=,enable=true,priority=800
  type=match,pattern=v(.*),group=1,suffix=,enable=false,value=,priority=800
  type=raw,priority=650,value=test,enable=true
  type=ref,event=branch,enable=true,priority=600
  type=ref,event=pr,prefix=pr-,enable=true,priority=600
Docker tags
  dashpay/tenderdash:test
  dashpay/tenderdash:fix-docker-tag

without input tag:


Processing tags input
  type=semver,pattern={{version}},value=,enable=true,priority=900
  type=match,pattern=v(\d+),group=1,value=,enable=true,priority=800
  type=match,pattern=v(\d+.\d+),group=1,value=,enable=true,priority=800
  type=match,pattern=v(\d+.\d+.\d+),group=1,value=,enable=true,priority=800
  type=match,pattern=v(.*),group=1,suffix=,enable=false,value=,priority=800
  type=raw,priority=650,value=,enable=false
  type=ref,event=branch,enable=true,priority=600
  type=ref,event=pr,prefix=pr-,enable=true,priority=600


Docker tags
  dashpay/tenderdash:fix-docker-tag

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review February 10, 2023 15:39
@lklimek lklimek enabled auto-merge (squash) February 10, 2023 15:40
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lklimek lklimek merged commit eed43d4 into v0.10-dev Feb 10, 2023
@lklimek lklimek deleted the fix-docker-tag branch February 10, 2023 15:41
shotonoff added a commit that referenced this pull request Feb 15, 2023
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
shotonoff added a commit that referenced this pull request Feb 22, 2023
* fix(build): docker tag is invalid for empty input.tag (#580)

* chore: bump up dashd-go version to v0.23.6 (#587)

---------

Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants