Skip to content

fix: signature verification#584

Merged
shotonoff merged 13 commits intov0.11-devfrom
stabilize-v0.11
Feb 15, 2023
Merged

fix: signature verification#584
shotonoff merged 13 commits intov0.11-devfrom
stabilize-v0.11

Conversation

@shotonoff
Copy link
Collaborator

@shotonoff shotonoff commented Feb 14, 2023

Issue being fixed or feature implemented

Tenderdash uses ThresholdVerify function (that is binding to bls::Threshold::Verify) to verify the signature of the message digest that doesn't compatible with core

What was done?

  • Use BasicSchemeMPL for signing and verifying operations
  • Replaced bls::Threshold::Verify on BasicSchemaMPL.Verify to be able to verify core's signature
  • Updated the version of BLS module (1.2.6)

How Has This Been Tested?

Drive can generate the blocks

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov
shumkov previously approved these changes Feb 15, 2023
Copy link
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shotonoff shotonoff merged commit e367071 into v0.11-dev Feb 15, 2023
@shotonoff shotonoff deleted the stabilize-v0.11 branch February 15, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants